Bug#868078: poco: Please add m68k as target to Double-Conversion
Source: poco
Version: 1.7.6+dfsg1
Severity: normal
Tags: patch
User: debian-68k@lists.debian.org
Usertags: m68k
Hi!
poco currently fails to build from source because the embedded
version of Double-Conversion lacks support for m68k:
g++ -Iinclude -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/CppUnit/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/CppUnit/WinTestRunner/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Foundation/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/XML/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/JSON/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Util/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Net/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Crypto/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/NetSSL_OpenSSL/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Data/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Data/SQLite/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Data/ODBC/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Data/MySQL/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/MongoDB/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/Zip/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/PageCompiler/include -I/<<BUILDDIR>>/poco-1.7.6+dfsg1/PageCompiler/File2Page/include -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/poco-1.7.6+dfsg1=. -fstack-protector-strong -Wformat -Werror=format-security -W
all -Wno-sign-compare -Wall -Wno-sign-compare -DPOCO_BUILD_HOST=vs91 -DPOCO_TARGET_OSNAME=Linux -DPOCO_TARGET_OSARCH=m68k -DPOCO_UTIL_NO_JSONCONFIGURATION -D_XOPEN_SOURCE=500 -D_REENTRANT -D_THREAD_SAFE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DPOCO_HAVE_FD_EPOLL -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -fPIC -c src/NumericString.cpp -o /<<BUILDDIR>>/poco-1.7.6+dfsg1/Foundation/obj/Linux/m68k/release_shared/NumericString.o
In file included from src/diy-fp.h:31:0,
from src/diy-fp.cc:29,
from src/NumericString.cpp:23:
src/utils.h:74:2: error: #error Target architecture was not detected as supported by Double-Conversion.
#error Target architecture was not detected as supported by Double-Conversion.
^~~~~
This is fixed by applying the attached patch which was cherry-picked
from Double-Conversion upstream [1]. poco upstream is missing the patch
as well as Double-Conversion upstream hasn't released since after the
patch [1] was merged in 2014.
Thanks for consideration!
Adrian
> [1] https://github.com/google/double-conversion/commit/da11179623145f53b204105a93b8bbca431141da
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Description: Add m68k as target architecture to Double Conversion
Origin: https://github.com/google/double-conversion/commit/da11179623145f53b204105a93b8bbca431141da
Last-Update: 2017-07-11
--- poco-1.7.6+dfsg1.orig/Foundation/src/utils.h
+++ poco-1.7.6+dfsg1/Foundation/src/utils.h
@@ -63,6 +63,8 @@
defined(__AARCH64EL__) || \
defined(nios2) || defined(__nios2) || defined(__nios2__)
#define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
+#elif defined(__mc68000__)
+#undef DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS
#elif defined(_M_IX86) || defined(__i386__) || defined(__i386)
#if defined(_WIN32)
// Windows uses a 64bit wide floating point stack.
Reply to: