Re: [PATCH 0/8] Amiga XSurf100 patch series, to be submitted to linux-net
Hi Geert,
On Tue, Nov 17, 2015 at 9:18 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Michael,
>
> On Tue, Nov 17, 2015 at 12:33 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
>> just as a heads-up, I've been working on getting this series ready for
>> submission to -net. The first six patches will need to be taken through
>> -net, the last two are m68k specific and might be equally well placed in
>> arch/m68k/amiga for preference.
>
> Please don't put drivers in arch/m68k/. drivers/net is fine for a pure-net
> driver.
OK, fine. arch/m68k/atai is where I had put the platform devices for
the Atari network and USB drivers, but these don't require much more
than a few register definitions.
>
>> Patch 6 and 8 are optional - the interrupts are handled just fine inside
>> ei_interrupt if generated by other users of IRQ_AMIGA_PORTS.
>>
>> If you know of some other hardware currently using IRQ_AMIGA_PORTS that
>> cannot handle shared interupts, give me a shout and I'll look into handling
>> this through a new interrupt controller for IRQ_AMIGA_PORTS.
>
> All Amiga devices should handle shared interrupts.
Good - do you see any merit in using a platform defined interrrupt
wrapper to 'protect' a driver interrupt from spurious calls?
> Thanks a lot for your work!
My pleasure, as always.
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Reply to: