[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Log for attempted build of webkit2gtk_2.6.2+dfsg1-4 on m68k (dist=unstable)



Alberto Garcia <berto@igalia.com> writes:

>> --- webkitgtk-2.8.0.orig/Source/WebCore/css/RuleSet.h
>> +++ webkitgtk-2.8.0/Source/WebCore/css/RuleSet.h
>> @@ -141,7 +141,7 @@ struct SameSizeAsRuleData {
>>      unsigned d[4];
>>  };
>>  
>> -COMPILE_ASSERT(sizeof(RuleData) == sizeof(SameSizeAsRuleData), RuleData_should_stay_small);
>> +COMPILE_ASSERT(sizeof(RuleData) <= sizeof(SameSizeAsRuleData), RuleData_should_stay_small);
>
> Can you summarize very briefly why these changes to COMPILE_ASSERT are
> only needed in this architecture?

It's because SameSizeAsRuleData overestimates the size of RuleData.  It
uses different types, with different sizes and alignments.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Reply to: