Re: [PATCH v3 2/4] m68k/atari - atafb: convert allocation of fb ram to new interface

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Michael,

On Mon, Mar 31, 2014 at 10:06 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
> The new atari_stram_alloc interface returns kernel virtual addresses
> even if the kernel runs in FastRAM. These addresses are not
> guaranteed to be identical with the physical addresses. Since ST-RAM
> mappings have not been set up by mem_init, virt_to_phys() and its
> cousin do not work and the atari_stram_to_phys() etc. helpers must
> be used to determine physical addresses.

Thanks!

> @@ -2213,7 +2214,7 @@ static int ext_encode_var(struct fb_var_screeninfo *var, struct atafb_par *par)
>
>  static void ext_get_par(struct atafb_par *par)
>  {
> -       par->screen_base = external_addr;
> +       par->screen_base =external_screen_base;

I'll add the missing space after "=".

> +               external_screen_base = ioremap_writethrough((unsigned long)external_addr,
>                                                      external_len);

I'll remove the now superfluous cast.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds