[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 03/18] [RFC] mi: Avoid division by zero errors in miInitializeColormap()



Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Question: Should we restrict depth < 3 to grayscale visuals instead?
> For monochrome this is already needed, as miCreateDefColormap() only
> preallocates black and white pixels if depth > 1.

Yes, it doesn't make sense to offer static color and true color for this
hardware. I'd suggest that miInitializeColormap should probably return
failure when trying to initialize a TrueColor or StaticColor colormap
where you're getting a color plane or line instead of a color cube :-)

-- 
keith.packard@intel.com

Attachment: pgp4J_e5AwlhZ.pgp
Description: PGP signature


Reply to: