Re: linux 3.10.1 with initrd (was Re: linux 3.8.12-1 (atari flavour) does not boot)
- To: Geert Uytterhoeven <geert@linux-m68k.org>
- Cc: Mikael Pettersson <mikpe@it.uu.se>, Thorsten Glaser <tg@mirbsd.de>, "Linux/m68k" <linux-m68k@vger.kernel.org>, Debian m68k <debian-68k@lists.debian.org>
- Subject: Re: linux 3.10.1 with initrd (was Re: linux 3.8.12-1 (atari flavour) does not boot)
- From: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
- Date: Fri, 2 Aug 2013 21:08:27 +1200
- Message-id: <[🔎] 0f1d3739660c2bece613948285afd937@biophys.uni-duesseldorf.de>
- In-reply-to: <CAMuHMdVj_xZWYc1Cszun0F6Xrrz0=e_EJN4b1cqdbcRqgC7ABg@mail.gmail.com>
- References: <alpine.DEB.2.02.1305132122190.14304@tglase.lan.tarent.de> <CAMuHMdX+t0=J+8a1JoF6Jf=gO_ROuL_kgAVjF0DJA-cgPGp_Ng@mail.gmail.com> <Pine.BSM.4.64L.1305132126170.11828@herc.mirbsd.org> <5192331E.9010009@debian.org> <Pine.BSM.4.64L.1305141338580.14676@herc.mirbsd.org> <20130514144112.GH11842@chumley.earth.sol> <Pine.BSM.4.64L.1305141642360.9568@herc.mirbsd.org> <Pine.BSM.4.64L.1307201716460.31890@herc.mirbsd.org> <CAMuHMdVj_xZWYc1Cszun0F6Xrrz0=e_EJN4b1cqdbcRqgC7ABg@mail.gmail.com>
Hi Geert,
[ 0.160000] WARNING: at /root/linux-3.10.1/init/main.c:698 do_one_initcall+0x12e/0x13a()
[ 0.160000] initcall param_sysfs_init+0x0/0x1a4 returned with disabled interrupts
This seems to happen for several initcalls. Geert et al,
can you have a look at them, they’re scary ☺
It only happens on multi-platform kernels, because of the following definition
of ALLOWINT:
#if defined(MACH_ATARI_ONLY)
/* block out HSYNC = ipl 2 on the atari */
#define ALLOWINT (~0x500)
#else
/* portable version */
#define ALLOWINT (~0x700)
#endif /* machine compilation types */
On an Atari-only kernel, flags is either 0x00c02204 or 0x00c02214.
Hence "flags & ~ALLOWINT" is "flags & 0x500" is always zero.
On a multi-platform kernel, flags is one of 0x00c02004, 0x00c02014,
0x00c02204, or 0x00c02214.
Hence "flags & ~ALLOWINT" is "flags & 0x700" is sometimes non-zero,
triggering the warning.
Anyone who sees a solution that doesn't involve adding a variable to hold
ALLOWINT?
We're already having a check for Q40 in arch_local_irq_enable()
(in multi-platfom kernels only).
Didn't we have that sorted out earlier? I seem to recall this has surfaced before.
What is the cause of the problem exactly - the hsync handler changing the IPL to block out further interrupts, whenever it is called for the first time after interrupts are enabled? We could stop doing that on multi-platform kernels (taking all hsync interrupts will be a performance hit but not stop the system from working).
Cheers,
Michael
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To UNSUBSCRIBE, email to debian-68k-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: http://lists.debian.org/CAMuHMdVj_xZWYc1Cszun0F6Xrrz0=e_EJN4b1cqdbcRqgC7ABg@mail.gmail.com
Reply to: