Re: linux 3.10.1 with initrd (was Re: linux 3.8.12-1 (atari flavour) does not boot)

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sat, Jul 20, 2013 at 7:27 PM, Thorsten Glaser <tg@mirbsd.de> wrote:
> So good, so far. An ARAnyM log of the build (kernel
> messages) is attached. There’s one thing sticking out:
>
> [    0.160000] WARNING: at /root/linux-3.10.1/init/main.c:698 do_one_initcall+0x12e/0x13a()
> [    0.160000] initcall param_sysfs_init+0x0/0x1a4 returned with disabled interrupts
>
> This seems to happen for several initcalls. Geert et al,
> can you have a look at them, they’re scary ☺

It only happens on multi-platform kernels, because of the following definition
of ALLOWINT:

#if defined(MACH_ATARI_ONLY)
        /* block out HSYNC = ipl 2 on the atari */
#define ALLOWINT        (~0x500)
#else
        /* portable version */
#define ALLOWINT        (~0x700)
#endif /* machine compilation types */

On an Atari-only kernel, flags is either 0x00c02204 or 0x00c02214.
Hence "flags & ~ALLOWINT" is "flags & 0x500" is always zero.

On a multi-platform kernel, flags is one of 0x00c02004, 0x00c02014,
0x00c02204, or 0x00c02214.
Hence "flags & ~ALLOWINT" is "flags & 0x700" is sometimes non-zero,
triggering the warning.

Anyone who sees a solution that doesn't involve adding a variable to hold
ALLOWINT?

We're already having a check for Q40 in arch_local_irq_enable()
(in multi-platfom kernels only).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds