[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: linux-2.6_2.6.38-5_m68k.changes ACCEPTED

On Thu, 12 May 2011, Ben Hutchings wrote:

> > arch/m68k/mac/misc.c: In function 'mac_hwclk':
> > arch/m68k/mac/misc.c:309: warning: 'result' may be used uninitialized in this function
> > arch/m68k/mac/misc.c:309: note: 'result' was declared here
> It is used before initialisation on the first iteration through line 
> 326.  I think it would be reasonable to initialise result.idata to 0 
> before entering the loop.

I recently wrote a patch that initialises result.idata using data from the 
RTC (which would be the intended algorithm as described in the comments) 
but I have not sent the patch as I have not yet found time to test it.

> > drivers/scsi/mac_scsi.c:220:5: warning: "NDEBUG_ABORT" is not defined 
> > drivers/scsi/mac_scsi.c:271:5: warning: "NDEBUG_ABORT" is not defined
> Should be #ifdef NDEBUG, not #if NDEBUG.

I patched this one years ago but decided against sending any mac_scsi 
patches until there was a plan for addressing other issues with NCR5380 
and mac_scsi...

Thanks Ben, for your exhaustive analysis of the compiler warnings.


Reply to: