[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gcc 4.5 and TLS

On Thu, Jun 03, 2010 at 06:12:29PM +0200, Andreas Schwab wrote:
> It is basically working quite well.  Unfortunately there is a big
> problem which becomes apparent when running the libstdc++ testsuite: the
> m68k compiler only guarantees a maximum alignment of 2 bytes, but the
> futex syscall requires 4 byte alignment.  So if your pthread mutex is
> not aligned on a 4 byte boundary this will result in passing an
> unaligned address to futex.  I haven't yet decided on what would be the
> best way to fix that.

I may be missing something obvious, but why don't we just change the
kernel to allow 2-byte alignment for m68k? The comment in futex.c
just says "natural" alignment but is then hard-coded for sizeof(u32).
What would break if we just changed the code in get_futex_key to
allow this?

	Brad Boyer

Reply to: