[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] m68k: Atari io.h fixes for EtherNAT driver

Hi Geert,

This fixes register access problems for the EtherNAT (SMC91C111) when used
together with the EtherNEC (ROM port NE2k clone). Tested on my Falcon.

Applies after Geert's linux-m68k-patches-2.6/atari-rom-isa.diff .... should
integrate accordingly in the Debian kernel source.

Sorry, it took a while...

NP - I only just got back ...

The patch idea looks fine to me.

--- a/include/asm-m68k/io.h
+++ b/include/asm-m68k/io.h
@@ -429,8 +429,8 @@
  * kernel with both ROM port ISA and IDE compiled in, those have
  * conflicting defs for in/out. Simply consider port < 1024
- * ROM port ISA and everything else regular ISA for IDE. read,write not

But it's seriously whitespace-challenged. Time to tame alpine?

Argh - time to find a replacement for pine/alpine perhaps. I'll send the patch as attachment (though vger sometimes chokes on that).

+ * Originally, insb/outsb and insw/outsw were set to the ROM variants in

Do we need this explanation in the comments? It's already in the patch

No, it can definitely be removed. I'll resend both this one and the EtherNEC one soon.


Reply to: