Re: Xorg on m68k

[Michael Schmitz <schmitz@granat.biophys.uni-duesseldorf.de>]

Hi,

> The text console is broken in 16 bpp, as atafb uses the atafb_iplan2p8*
> drawing operations for both 8 and 16 bpp. The patch below is a first
> step to fix this, but it doesn't work yet as the cfb_*() routines need
> valid numbers in fb_fix_screeninfo.line_length, which is not set up by atafb.

What would that line_length be, I wonder - just yres*2?

> Oh well, may the all night hackers fix it ;-)
>
> ---
>  drivers/video/atafb.c |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> --- a/drivers/video/atafb.c
> +++ b/drivers/video/atafb.c
> @@ -2549,6 +2549,13 @@ static void atafb_fillrect(struct fb_inf
>  	if (!rect->width || !rect->height)
>  		return;
>
> +#ifdef ATAFB_FALCON
> +	if (info->var.bits_per_pixel == 16) {
> +		cfb_fillrect(info, rect);
> +		return;
> +	}
> +#endif
> +
>  	/*
>  	 * We could use hardware clipping but on many cards you get around
>  	 * hardware clipping by writing to framebuffer directly.

Which reminds me - that part of the code could use a cleanup anyway. We'll
see about that...

	Michael