[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: help with an upstream test suite problem?

On Wed, 23 Nov 2005, Paul Wise wrote:

> On Thu, 2005-11-24 at 00:21 +1100, Finn Thain wrote:
> > A quick look at the rest of the code shows that util.h tests
> > #ifndef __BIG_ENDIAN__
> > which probably doesn't work because it needs the right header.
> True, but I don't think that is relevant to SWAP_ENDIAN_INT32 because it
> is outside that #ifndef.

FIX_ENDIAN_INT32_INPLACE is inside the ifdef, and it is used by 
testFixEndian() in endian.cpp, which is why the actual = 0x12345678, and 
not 0x78563412.


> My reading of SWAP_ENDIAN_INT32 says that is should work no matter what 
> endianess the machine is. Of course I don't know anything about m68k.
> > #include <endian.h>
> > works under Linux, though it probably isn't portable.
> I'll let upstream know about that.

Reply to: