[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: How to create a proper size UDF image?



Hi Jörg,

This patch works. All the file names can be read successfully. Thank you.
But the longest name is truncated by one char without any warning message. IMHO, it's better to add an option that those too long names are reported instead of being truncated directly.


------------------
WF
 
 
 
------------------ Original ------------------
Date:  Thu, Jan 25, 2018 02:01 AM
To:  "feng.wang"<feng.wang@aaadisc.com>; "cdwrite"<cdwrite@other.debian.org>;
Subject:  Re: How to create a proper size UDF image?
 
?? <feng.wang@aaadisc.com> wrote:

> Hi Jörg,
>
>
> > I just verified that your problem is also present on Solaris, so I would need to
> fix it in mkisofs.
>
> > This may take a few days, as I need to understand what's happening when there
> are more than 2 of these characters....

Hi, could you test this patch:


------- joliet.c -------
--- /tmp/sccs.D8aOtz 2015-12-30 19:04:32.953572000 +0100
+++ joliet.c 2018-01-24 19:00:01.459473000 +0100
@@ -257,6 +257,8 @@
  unsigned char uc;
  int jsize = size;
 
+ jsize = strlen(source);
+
  /*
  * If we get a NULL pointer for the source, it means we have an
  * inplace copy, and we need to make a temporary working copy first.
@@ -344,6 +346,8 @@
  unichar = '_';
  }
  all_chars:
+ if (unichar == 0)
+ unichar = '_';
  ;
  }
  buffer[i] = unichar >> 8 & 0xFF; /* final UNICODE */


Jörg

--
 EMail:joerg@schily.net                    (home) Jörg Schilling D-13353 Berlin
    joerg.schilling@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL: http://cdrecord.org/private/ http://sf.net/projects/schilytools/file

Reply to: