Bug#1064087: RFS: asn/0.75.3-1 [ITP] -- network OSINT CLI ASN, RPKI, BGP, Geo, Recon, Trace

[Sergio Durigan Junior <sergiodj@debian.org>]

On Friday, February 16 2024, Marcos Rodrigues de Carvalho wrote:

> Dear mentors,
>
> I am looking for a sponsor for my package "asn":

Thanks, Marcos.  Here's my review.

* d/copyright:

The full name of the package author is available in the LICENSE file.
You need to use it when writing the d/copyright entry.

* d/control:

I've never seen X-Lintian-Overrides before, and I don't think it's
recognized by Lintian.  Please remove it (and add a proper
lintian-overrides file if necessary).

* d/watch:

Minor nitpick, but the file doesn't end with a newline.

* d/manpage/asn.1

Thanks for writing a manpage!  Did you write it manually, or did you use
some software to generate it?  If the latter, then I'd suggest adding
the original source for the manpage and generating it during build time.

I have a few comments about its style:

- I believe the "TARGET" section needs be better organized.  I think you
  should itemize each possible target and separate them with a newline
  or something.

- Same comment for "SERVER OPTIONS".  In fact, according to the README
  file, there are a few more server options than what you're listing.

- You forgot to edit the "AUTHOR" section :-).

* General comments:

You're using gbp, and you chose a non-standard branch name for the
master (Debian) branch.  Therefore, you need to provide a d/gbp.conf
which teaches gbp how to find your Debian branch.

Also, unless you have a very good reason not to, this package should be
placed under the "debian" namespace on Salsa.  I can create a repository
there and give you permissions if you want.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/