Control: tags -1 moreinfo
Hi Igor,
a short, but incomplete review on multispeech_4.6.0-4.dsc, Uploaded 2023-11-24 12:24
(For example, I did not do a d/copyright review.)
d/changelog:
- An initial upload to Debian only have one single entry, like
"Initial Upload (Closes: #<your-itp-bug>)"
(There are by definition no changes to the packaging on initial
upload.)
- As an consequence, the debian revision must stay at -1 until
sponsored.
d/compat
- is obosolete, switch to B-D on debhelper-compat mechanisxm
- compat level 10 is ancient. Update to 13. See
debhelper-compat-upgrade-checklist(7) for what has changed.
d/control:
- Standard Version is too old, update to 4.6.2, check the policy-upgrade
checklist for changes.
- It B-D on cbds. cbds should no longer be used for new packages.
Convert to the debhelper sequencer.
- It Recommends/Suggests/Conflicts on packages not in Debian, please
clean up here. (Do not recommend/suggest those packages)
For the conflict:
- libmultispeech5 conflicts on packages libmultispeechX (with X=0
and 3). Even if the packages are not in Debian, this indicates
that either
- libmultispeechX had packaging issues.
- you are not aware that libmultispeechX must be co-installable,
and if they aren't the package needs to be fixed.
(Update: it is packaing errors, see below)
- (the conflicts might be useful to transition existing users to
the Debian packages, if the Debian package would fail to
install, but this would then be removed after trixie becomes
stable.)
- A library package needs a development package too.
d/rules:
- Use the debhelper sequencer ("dh_")
d/libmultispeech5.install
- You are not using multiarch.
- the library package must only contain the library, not configuration
files nor manpages. (makes them breaking when an SONAME bump is
required - see above about your Conflicts)
d/libmultispeech.shlibs
- Why do you need this file?
d/libmultispeech.links
- why do you need the link? Is multispeech to be invoked by the user
directly or is it only to be invoked by emacs? (as the
usr/share/emacs seems to indicate)
(Disclaimer: I do not know anything about emacs extension.)
(not required but for consistency:)
- the files d/docs d/install etc. should be names <package>.docs
<package>.install to make it more obvious where they go. Of course
this is defined by d/control when not doing so, but it helps
understanding whats going on and also protects from problems if
the package order in d/control is changed for whatever reason.)
prerm
- not sure what your plans are with prerm, (should it be postrm?) what
you want to archive, but note that debconf questions should only be
removed when the package is purged.
- use dh_installdebconf, if possible, instead.
postinst
- speech-dispatcher is using a systemd service file, if you really
need to reload its configuration, you should use service
speech-dispatcher reload and not kill it via kill. (you might
overkill)
- build log has warnings, for exmple:
dpkg-gencontrol: warning: package multispeech: substitution variable ${perl:Depends} unused, but is defined
dpkg-gencontrol: warning: package multispeech: substitution variable ${perl:Depends} unused, but is defined
- lintian:
+++ lintian output +++
su: warning: cannot change directory to /nonexistent: No such file or directory
I: libmultispeech5: conflicts-with-version multispeech (<< 4.0.0)
I: multispeech source: debian-watch-file-is-missing
I: libmultispeech5: hardening-no-bindnow [usr/lib/libmultispeech.so.5.1.2]
I: multispeech: hardening-no-bindnow [usr/bin/multispeech]
I: sd-multispeech: hardening-no-bindnow [usr/lib/speech-dispatcher-modules/sd_multispeech]
I: libmultispeech5: hardening-no-fortify-functions [usr/lib/libmultispeech.so.5.1.2]
I: multispeech: hardening-no-fortify-functions [usr/bin/multispeech]
I: sd-multispeech: hardening-no-fortify-functions [usr/lib/speech-dispatcher-modules/sd_multispeech]
I: multispeech source: no-dh-sequencer [debian/rules]
I: libmultispeech5: no-symbols-control-file usr/lib/libmultispeech.so.5.1.2
I: multispeech source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.6.2)
I: libmultispeech5: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man5/multispeech.conf.5.gz:134]
I: libmultispeech5: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man5/multispeech.conf.5.gz:157]
I: libmultispeech5: typo-in-manual-page "allows to" "allows one to" [usr/share/man/man5/multispeech.conf.5.gz:186]
I: multispeech: unused-debconf-template shared/emacspeak/groupies [templates:104]
I: multispeech: unused-debconf-template shared/emacspeak/invalidport [templates:92]
I: multispeech: unused-debconf-template shared/emacspeak/invaliduser [templates:166]
I: multispeech: unused-debconf-template shared/emacspeak/rootgroup [templates:188]
P: multispeech source: package-uses-old-debhelper-compat-version 10
P: multispeech source: silent-on-rules-requiring-root [debian/control]
On Tue, Nov 14, 2023 at 07:52:5V7PM +0300, Igor B. Poretsky wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "multispeech":
>
> * Package name : multispeech
> Version : 4.6.0-1
> Upstream contact : Igor B. Poretsky <poretsky@mlbox.ru>
> * URL : https://github.com/poretsky/multispeech
> * License : GPL-2.0
> * Vcs : https://github.com/poretsky/multispeech
> Section : sound
>
> The source builds the following binary packages:
>
> multispeech - Multilingual speech server for Emacspeak
> sd-multispeech - Multilingual Speech Dispatcher backend
> libmultispeech5 - Multilingual speech server
>
> To access further information about this package, please visit the following URL:
>
> https://mentors.debian.net/package/multispeech/
>
> Alternatively, you can download the package with 'dget' using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/m/multispeech/multispeech_4.6.0-1.dsc
>
> Changes for the initial release:
>
> multispeech (4.6.0-1) unstable; urgency=medium
> .
> * Debian package has been separated from the upstream sources.
> * Switch to dpkg-source 3.0 format.
> * Debian package release. (Closes: #1055902)
>
> Regards,
> --
> Igor
>
Attachment:
signature.asc
Description: PGP signature