[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010663: RFS: strawberry/1.0.4-1 [ITP] -- Audio player and music collection organizer



On 27/05/2022 11:11, Paul R. Tagliamonte wrote:
I searched my records and found the rejection. Looks like it's fixable. Quoted here and I've cc'd the ftpteam if anyone has questions

+----------------------+
|   REJECT reasoning   |
+----------------------+

A trainee points out:

ext\libstrawberry-common\core\scoped_nsautorelease_pool.mm <http://scoped_nsautorelease_pool.mm> has a different
license and copyright holders

src\engine\enginebase.cpp and others not accounted for by d/copyright.

src\widgets\qsearchfield_mac.mm <http://qsearchfield_mac.mm> and src\widgets\qsearchfield_nonmac.cpp not
accounted for by d/copyright.

+----------------------+
|    Other comments    |
+----------------------+

d/copyright does not account for ext\libstrawberry-common\core\logging.cpp.

src/dbus/*.xml are from a different project so presumably different copyright
holders?

+----------------------+
|         N.B.         |
+----------------------+

This review may not be exhaustive.  Please check your source package
against your d/copyright and the ftpmaster REJECT-FAQ, throughly,
before uploading to NEW again.

Thank you for your time and contribution!



Cheers,
 paultag


Thanks for that Paul,

Some of these have been fixed already.
I've added missing files to the Chromium Authors paragraph
and added a src/dbus/*.xml paragraph.

Updated debian/copyright and uploaded to Mentors & Salsa

Cheers,
Peter


Reply to: