Bug#783529: RFS: spacenavd/0.6-1 [ITA]
Hi Rodolphe,
On Sun, May 17, 2015 at 5:24 AM, Rodolphe PELLOUX-PRAYER
<rodolphe@damsy.net> wrote:
> Vincent,
>
> Le 17/05/2015 01:39, Vincent Cheng a écrit :
>> Hi Rodolphe,
>>
>> On Sat, May 16, 2015 at 1:23 PM, Rodolphe PELLOUX-PRAYER
>> <rodolphe@damsy.net> wrote:
>>> Hi Vincent,
>>>
>>> Thx for your review!
>>>
>>>> debian/copyright is missing a few entries:
>>>> - src/serial/*: Copyright 1997-2001 John E. Stone (j.stone@acm.org),
>>>> 3-clause BSD (+ upstream author)
>>>
>>> Should be fixed.
>>
>> You're also missing Thomas Anderson <ta@nextgenengineering.com> as the
>> copyright holder for a number of files in src/magellan/. (In case you
>> haven't done so already, please take the time to do a thorough
>> license/copyright check yourself when adopting/packaging new
>> packages.)
>
> Damn, you're right, I definitely need to check more carefully the
> licenses and copyrights! licensecheck seems to be a good helper :)
>
>> By the way, I also suggest that you use start-stop-daemon in your
>> sysvinit script, especially since you're shipping a script of your own
>> here.
>
> Init script updated.
>
>
> The new version is there :
> http://mentors.debian.net/package/spacenavd
Looks good, except for one last thing I should've checked earlier
(sorry for these piecemeal reviews); your orig tarball doesn't seem to
match the tarball distributed upstream:
upstream md5sum: 7e2c04fb8dbb7d39b9ee7b64565e0c4f
mentors.d.n tarball md5sum: 0fbcb66a9ef8368fb3de5397b14eb991
Please ensure that you're using the same tarball as upstream is; if
you must repack it (e.g. to satisfy DFSG), please change the version
string (appending +dfsg is typical in this scenario) and add a brief
explanation to d/README.source or d/copyright. If you're using
git-buildpackage or similar helpers without e.g. pristine-tar, or some
other way of reconstructing pristine tarballs, you're going to end up
with a tarball with a different hashsum as well.
(Also, re: #781185, you didn't actually retitle the wnpp bug and set
yourself as owner.)
Regards,
Vincent
Reply to: