[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#752116: RFS: drmips/1.2.2-1 [ITP]



tags 752116 moreinfo
thanks


Hi Bruno,

Please:

1. Change the DH level from 8 to 9.

2. d/control:
    - Debian no have a section 'education'. Please, choose a section
here[1]. Use the contract name of the section. As example, for
miscellaneous, use misc. How to know this? Click over the section and
use the name showed in head.
    - I think that Vsc-Git should be
'https://bitbucket.org/brunonova/drmips -n debian'. Could you provide
a Vcs-Browser field?
    - Remove ${shlibs:Depends} because interpreted languages don't use it.
    - In long description, put a dot between the first and second paragraphs.
    - In long description, what is FEUP? Where (country) is FEUP?

[1] https://packages.debian.org/unstable/

3. d/copyright:
    - You must list all authors and licenses in thos file. Use the
command 'egrep -sriA25 '(public domain|copyright)' *' to help you.
    - From Debian policy[2]:

"Packages distributed under the Apache license (version 2.0), the
Artistic license, the GNU GPL (versions 1, 2, or 3), the GNU LGPL
(versions 2, 2.1, or 3), and the GNU FDL (versions 1.2 or 1.3) should
refer to the corresponding files under
/usr/share/common-licenses,[119] rather than quoting them in the
copyright file."

    - I suggest you to use the conventional license texts provided by
Debian, when applicable. These text are available at
/usr/share/debhelper/dh_make/licenses/.

[2] https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

4. d/drmips.1: you are the upstream. Why you don't include the manpage
in source tarball? idem to drmips.desktop, drmips.pt.1 and drmips.xpm.

5.d/links: I didn't understand your intend with this file.

6. d/rules: please, remove the trash (from '# -*- makefile' to 'verbose mode').

7. After build we have some Lintian messages that you can solve (as
packager and as upstream):

a. Maybe you can solve:

P: drmips source: source-contains-prebuilt-java-object
src/android/DrMIPS/libs/android-support-v4.jar
P: drmips source: source-contains-prebuilt-java-object
src/pc/DrMIPS/lib/JTattoo.jar
P: drmips source: source-contains-prebuilt-java-object
src/pc/DrMIPS/lib/autocomplete.jar
P: drmips source: source-contains-prebuilt-java-object
src/pc/DrMIPS/lib/rsyntaxtextarea.jar

b. You can solve:

P: drmips source: debian-watch-may-check-gpg-signature
P: drmips: no-upstream-changelog

PS: I would like to suggest you to add a GPG signature for your
upstream code. To see more details, '$ man uscan' (search for
pgpsigurlmangle). To sign your tarball, you can use 'gpg -ab
<tarball_name>'.

c. You should use a Lintian override (first line must be a comment
about the issue):

I: drmips source: ored-build-depends-on-obsolete-package
build-depends: openjdk-6-jdk
I: drmips: ored-depends-on-obsolete-package depends: openjdk-6-jre

8. Your package doesn't build twice. To fix it, you must create an
override to dh_clean in d/rules (man dh) to remove these files and
directories:

src/android/DrMIPS/libs/DrMIPSSimulator.jar
src/pc/DrMIPS/lib/DrMIPSSimulator.jar
src/android/DrMIPS/res/raw/
src/pc/DrMIPS/cpu/

Thanks for your work.

Cheers,

Eriberto


2014-06-19 15:22 GMT-03:00 Bruno Nova <brunomb.nova@gmail.com>:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "drmips"
>
> * Package name    : drmips
>   Version         : 1.2.2-1
>   Upstream Author : Bruno Nova <brunomb.nova@gmail.com>
> * URL             : https://bitbucket.org/brunonova/drmips/
> * License         : GPL
>   Section         : education
>
> It builds those binary packages:
>
>   drmips     - Educational MIPS simulator - DrMIPS
>
> To access further information about this package, please visit the following
> URL:
>
> http://mentors.debian.net/package/drmips
>
>
> Alternatively, one can download the package with dget using this command:
>
>   dget -x
> http://mentors.debian.net/debian/pool/main/d/drmips/drmips_1.2.2-1.dsc
>
>
> Regards,
>  Bruno Nova


Reply to: