[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#857632: marked as done (apt: ignore the currently running kernel if attempting a reproducible build)

Your message dated Sat, 01 Apr 2017 21:03:46 +0000
with message-id <E1cuQBW-000AhH-8N@fasolo.debian.org>
and subject line Bug#857632: fixed in apt 1.4
has caused the Debian Bug report #857632,
regarding apt: ignore the currently running kernel if attempting a reproducible build
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
857632: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857632
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: apt
Severity: wishlist
Version: 1.4~rc2
Tags: patch

Hi,

Attached is the following:

  commit bf005711cb06380fa32c93f32bb4a2563b952b65
  Author: Chris Lamb <lamby@debian.org>
  Date:   Mon Mar 13 11:02:49 2017 +0100
  
      apt-auto-removal: Ignore the currently running kernel if attempting a reproducible build.
      
      If one is attempting to create a reproducible ISO image we do not want to
      include the build system's kernel version, not only due to it breaking
      reproducibility, but it could be somewhat misleading and/or the wrong thing
      to put in this file anyway.
  
   debian/apt.auto-removal.sh | 7 ++++++-
   1 file changed, 6 insertions(+), 1 deletion(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

>From bf005711cb06380fa32c93f32bb4a2563b952b65 Mon Sep 17 00:00:00 2001
From: Chris Lamb <lamby@debian.org>
Date: Mon, 13 Mar 2017 11:02:49 +0100
Subject: [PATCH] apt-auto-removal: Ignore the currently running kernel if
 attempting a reproducible build.

If one is attempting to create a reproducible ISO image we do not want to
include the build system's kernel version, not only due to it breaking
reproducibility, but it could be somewhat misleading and/or the wrong thing
to put in this file anyway.
---
 debian/apt.auto-removal.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/debian/apt.auto-removal.sh b/debian/apt.auto-removal.sh
index df9048cd6..2c32b0c9d 100644
--- a/debian/apt.auto-removal.sh
+++ b/debian/apt.auto-removal.sh
@@ -29,6 +29,11 @@ unamer="$(uname -r | tr '[A-Z]' '[a-z]')"
 if [ -n "$unamer" ]; then
 	running_version="$(echo "$list" | awk "\$1 == \"$unamer\" { print \$2;exit; }")"
 fi
+# ignore the currently running version if attempting a reproducible build
+if [ -n "${SOURCE_DATE_EPOCH}" ]; then
+	unamer=""
+	running_version=""
+fi
 latest_version="$(echo "$debverlist" | sed -n 1p)"
 previous_version="$(echo "$debverlist" | sed -n 2p)"
 
@@ -62,7 +67,7 @@ $list
 # list of different kernel versions:
 $debverlist
 # Installing kernel: $installed_version ($1)
-# Running kernel: $running_version ($unamer)
+# Running kernel: ${running_version:-ignored} (${unamer:-ignored})
 # Last kernel: $latest_version
 # Previous kernel: $previous_version
 # Kernel versions list to keep:
-- 
2.11.0

--- End Message ---
--- Begin Message --- 
Source: apt
Source-Version: 1.4

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 857632@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julian Andres Klode <jak@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Apr 2017 21:39:37 +0200
Source: apt
Binary: apt libapt-pkg5.0 libapt-inst2.0 apt-doc libapt-pkg-dev libapt-pkg-doc apt-utils apt-transport-https
Architecture: source
Version: 1.4
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Julian Andres Klode <jak@debian.org>
Description:
 apt        - commandline package manager
 apt-doc    - documentation for APT
 apt-transport-https - https download transport for APT
 apt-utils  - package management related utility programs
 libapt-inst2.0 - deb package format runtime library
 libapt-pkg-dev - development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - documentation for APT development
 libapt-pkg5.0 - package management runtime library
Closes: 855891 856723 857632
Changes:
 apt (1.4) unstable; urgency=medium
 .
   * The April Fools' Release
 .
   [ Julian Andres Klode ]
   * Ignore \.ucf-[a-z]+$ like we do for \.dpkg-[a-z]+$
   * Fix mistake in CHANGEPATH comment example
 .
   [ Chris Lamb ]
   * auto-removal: Ignore running kernel if attempting a reproducible build
     (Closes: #857632)
 .
   [ Joe Dalton ]
   * Danish program translation update (Closes: #856723)
 .
   [ David Kalnischkies ]
   * Fix and avoid quoting in CommandLine::AsString (LP: #1672710)
   * Ignore AutomaticRemove conffile option in upgrade (Closes: #855891)
Checksums-Sha1:
 e7daf021089f462a0a9851f80ae47b3c41cf9f97 2541 apt_1.4.dsc
 a1cf3b4d45b5140317954634984bc7582db54451 2076104 apt_1.4.tar.xz
 8e1d40b242228cebeaffd4248d2732cbbda10554 7556 apt_1.4_source.buildinfo
Checksums-Sha256:
 ae69ca34d14062b676e005de2415de2236c0b38c03496675d86f5ee725a3fcaa 2541 apt_1.4.dsc
 933cc255e7d053d93a08ccd0e027d762a8a621e4f2ec0977b0b326893da163fc 2076104 apt_1.4.tar.xz
 906fd4ca179f7b3b1d4185d58be0cfd5631065c6395b954a37e73366efb3dfb6 7556 apt_1.4_source.buildinfo
Files:
 a5678f4c8852537ba7aeefdfae72e2d9 2541 admin important apt_1.4.dsc
 10042b4b910056a15c3357d7ed8d0acd 2076104 admin important apt_1.4.tar.xz
 dbd171682fca7d92fa318a1b32a5461e 7556 admin important apt_1.4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEzeVhi4gF/W4gLOnC1zw55WWAs4YFAljgAyIPHGpha0BkZWJp
YW4ub3JnAAoJENc8OeVlgLOGLsoP/RUIQllQk+RTVGPcIw2nHGD1TW/ORx+WSU56
Kp87KGEuMqd9FPW3lsp3pPwHJ/VNCd0rC3WZex7B1V2dqSoRXRaufm8E1Ax0Lzsl
NJh5eBefeX3E3jSZFN1P11Ve6NpRVBE2FFremHC/991h417xZLjT7YUvqDrwHBRr
6AlyeW1XGnmivacgw9WCQZ2kLJi/JvE10EOxgDOFgkYDq5XHAJInpjbeg9G8CHLq
HdGIoiw6uXZq0FUciZuyzfiLoO1zeChWfS21NUBmLcyqDdG5qpg0dkkdneJ7lBvu
acSPN4EuW5gr7pWWGVZ6RznKy9dgOx1jcsHILP6Xob7lXtRlzQKb7Lq3Zh+RkC/7
rE5vdHPWlcMTXA5PE4PCsng0swlrmUwGVid15eyk/57f2K9GwP8AwtekILBE375y
gCoatIrCB1kaBv0yYGlLeSccmA7kYX6D+OJXPV+2KKXvsVx/vUKFdYM8+zaNu+/0
pRbNekD1CxAJOBpT9ucsJcx2Eu5w3UM5niwPeriVysVIQD8kbJOsHb+vVb0j2KdB
HxDnOYwb5dLYNTL5fSh7UwQ3yRpUHNK8dBtyrTCSqNUGKNbKEfoMzFqB2EirhpqV
3wv9kHSW6hH4BmQbY1qV/Rorx6He3djFlAAVflzo+03NstA3qf4rBetT2uLHiV29
Zb/SxM6S
=SCMX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: