Bug#478171: python-apt should accept '@' in mirror adresses
Subject: python-apt should accept '@' in mirror adresses
Package: python-apt
Version: 0.7.4ubuntu7
Severity: wishlist
Tags: patch
*** Please type your report below this line ***
It's currently impossible to use a mirror adress containing '@', which can
accur when using a non anonymous ftp.
To reproduce:
1) add this line to /usr/share/python-apt/templates/Ubuntu.mirrors :
ftp://login:pass@ftp.somewhere.org/ubuntu/
2) Launch software-properties-kde (not tested with software-properties-gtk,
but it should be the same)
3) Look at the list of mirrors : the one we just added isn't there.
Who to solve this :
python-apt can handle such url, the regular expression testing urls just
doesn't allow it.
In file aptsources/distinfo.py , line 132 :
match_mirror_line = re.compile(r"^(#LOC:.+)|(((http)|(ftp)|(rsync)|(file)|
(https))://[A-Za-z/\.:\-_]+)$")
juste add '@' to the allowed character. The result is :
match_mirror_line = re.compile(r"^(#LOC:.+)|(((http)|(ftp)|(rsync)|(file)|
(https))://[A-Za-z/\.:\-_@]+)$")
And that's all.
-- System Information:
Debian Release: lenny/sid
APT prefers hardy-updates
APT policy: (500, 'hardy-updates'), (500, 'hardy-security'),
(500, 'hardy-backports'), (500, 'hardy')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-16-generic (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages python-apt depends on:
ii apt [libapt-pkg-libc6.7 0.7.9ubuntu17 Advanced front-end for dpkg
ii apt-utils [libapt-inst- 0.7.9ubuntu17 APT utility programs
ii libc6 2.7-10ubuntu3 GNU C Library: Shared libraries
ii libgcc1 1:4.2.3-2ubuntu7 GCC support library
ii libstdc++6 4.2.3-2ubuntu7 The GNU Standard C++ Library v3
ii lsb-release 3.2-4ubuntu1 Linux Standard Base version
report
ii python 2.5.2-0ubuntu1 An interactive high-level
object-o
ii python-central 0.6.5ubuntu1 register and build utility for
Pyt
python-apt recommends no packages.
-- no debconf information
Reply to: