[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#239341: xdm: extraneous TCP port introduced in upstream



Package: xdm
Version: 4.3.0-7
Severity: normal
Followup-For: Bug #239341

Hmm. The TCP port opening was introduced in xc/programs/xdm/socket.c,
revision 3.11, when they removed the lines:

if (request_port == 0)   
    return;

which also got backported to 4_3_0_2.
See here:
http://cvsweb.xfree86.org/cvsweb/xc/programs/xdm/socket.c#rev3.10.4.1

The xdmcp listening socket code was ripped out of
CreateWellKnownSockets(), and my guess is that the check for
request_port == 0 went accidentally. I don't see why you would want a
randomly-selected chooser socket if you're not going to listen for the
well-known UDP requests. 

I'm not familiar enough with this code to actually submit a patch. Can
somebody with more clue check this out? Or maybe this should just be
forwarded upstream.



Reply to: