On Tue, Oct 21, 2003 at 05:55:11PM -0500, X Strike Force SVN Repository Admin wrote: > Author: rmh > Date: 2003-10-21 17:54:56 -0500 (Tue, 21 Oct 2003) > New Revision: 684 > > Modified: > branches/4.3.0/sid/debian/changelog > branches/4.3.0/sid/debian/patches/056_i810_make_i830_usable.diff > Log: > * Fix build error when NOT_BUILDING_X_SERVER=yes. The "pI830" variable > introduced in patch 056 is used unconditionaly, but only declared when > XF86DRI macro is defined. [Robert Millan] > - debian/patches/056_i810_make_i830_usable.diff: only access pI830 when > XF86DRI is defined. Say what? Why is the source file xc/programs/Xserver/hw/xfree86/drivers/i810/i830_driver.c being dealt with at all when NOT_BUILDING_X_SERVER is defined? (Oh, I get it. You're using NOT_BUILDING_X_SERVER prescriptively, by defining it when you run debian/rules or something similar, not descriptively. I'm not sure that's a good idea. If I'd meant NOT_BUILDING_X_SERVER to be used prescriptively, I'd have called it DO_NOT_BUILD_X_SERVER.) Can you please post the build failure to the list? Either way, we need to come up with a better commit log and changelog entry. Your description of the error is not meaningful in the context of the XFree86 build itself. -- G. Branden Robinson | The National Security Agency is Debian GNU/Linux | working on the Fourth Amendment branden@debian.org | thing. http://people.debian.org/~branden/ | -- Phil Lago, Deputy XD, CIA
Attachment:
signature.asc
Description: Digital signature