[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924140: marked as done (README: please mention STRICT_ERROR_CHECKS=1 USE_SAMPLE_FILES=1)

Your message dated Sun, 07 Jun 2020 14:11:15 +0000
with message-id <5edcf583dae2e_148b2b010f15e5c4142c6@godard.mail>
and subject line Bug#924140 fixed in www.debian.org
has caused the Debian Bug report #924140,
regarding README: please mention STRICT_ERROR_CHECKS=1 USE_SAMPLE_FILES=1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
924140: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924140
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: www.debian.org
Severity: normal
User: www.debian.org@packages.debian.org
Usertags: scripts

Hi,

While working on rebuilding the website within stretch and buster, I've
noticed the following.

It was a bit surprising to see that many errors, either due to missing
dependencies, or missing data, were not leading to a global failure when
the top-level make returns.

It was also a bit surprising to see that some targets couldn't get
processed successfully.

It turned out that the former issue is at least partiallly fixed by
setting STRICT_ERROR_CHECKS=1; the latter can be worked around by
setting USE_SAMPLE_FILES=1, which sets up some sample data files for
files that would otherwise be set up by some sync scripts getting run
from cron. Examples include:

    $(ENGLISHSRCDIR)/devel/people.names
    $(DATADIR)/Maintainers
    $(ENGLISHSRCDIR)/$(CUR_DIR)/data/%
    $(L10N_DIR)/data/%
    $(ENGLISHDIR)/mirror/Mirrors.masterlist

That was implemented in:
  https://salsa.debian.org/webmaster-team/webwml/commit/f0290accd46ee45383b56b9acc9624f5707f6b0e

(Thanks, Wouter!)

It seems to me it would make sense to mention both variables in the
top-level README, so that people interested in working on a full build
wouldn't have to figure out why some targets seem to be missing or not
defined, and to track down individual READMEs like:

     english/mirror/Mirrors.masterlist.README

FWIW, that's also what's getting used for CI, see:

    README_CI.gitlab-ci.yml


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

--- End Message ---
--- Begin Message --- 
Hello,

Bug #924140 in www.debian.org reported by you has been fixed in the Git repository.
You can see the commit message below and you can check the diff of the fix at:

https://salsa.debian.org/webmaster-team/webwml/-/commit/86b9f1a3f2135f424c79e44ae3d2972465aac119

------------------------------------------------------------------------
mention STRICT_ERROR_CHECKS=1 and USE_SAMPLE_FILES=1. Closes: #924140
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/924140

--- End Message ---
Reply to: