Bug#932811: example page without "To report a problem with the web site..." footer
Hi
This is what I have figured out:
The footer template prints or not the fineprint "To report a problem with the
website..." depending on a variable NOCOMMENTS. If it's set to "", the fineprint
is shown:
https://salsa.debian.org/webmaster-team/webwml/blob/master/english/template/debian/footer.wml#L159
to L162
The value of the variable is set in other templates, or individual wml files. I
have searched for "NOCOMMENTS" in the english subfolder on the website and tried
to figure out the reasoning behind hiding the "fineprint" in those pages.
Looking at the list of pages:
template/debian/cdimage.wml:99:#use wml::debian::basic LINK="#8c4939"
VLINK="#45241c" ALINK="#ff2600" NOCOMMENTS=true
template/debian/projectnews/header.wml:7:#use wml::debian::template
title="<debianprojectnews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)"
NOHOMELINK="yes" BARETITLE="yes" NOCOMMENTS="yes" SUMMARY="$(SUMMARY)"
template/debian/weeklynews/header.wml:5:#use wml::debian::template
title="<debianweeklynews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)"
NOHOMELINK="yes" BARETITLE="yes" NOCOMMENTS="yes" SUMMARY="$(SUMMARY)"
contact.wml:1:#use wml::debian::template title="Getting in Contact with Us"
NOCOMMENTS="yes"
template/debian/consultant.wml:12:#use wml::debian::basic SUMMARY="$(SUMMARY)"
title="<consultanttitle/>" NOCOMMENTS="yes" NOCOPYRIGHT="yes"
consultants/index.wml:1:#use wml::debian::template title="Consultants"
NOCOMMENTS="yes" GENTIME="yes"
legal/privacy.wml:1:#use wml::debian::template title="Privacy Policy"
NOCOMMENTS="yes"
I guess the general fineprint has been removed in the pages using a template
that provides another "contact" info, to avoid people contacting debian-www@
mailing list with CD/DVD issues, or publicity topics, etc.
We could solve this bug, then, removing the NOCOMMENTS="yes" and the
NOCOMMENTS=true in the wml files (and template files) where they are present.
I'm not sure about other people's opinion about showing the fineprint in *every
page*, so I'm attaching a patch for others to review and comment.
If there are no objections, I would apply the patch in one week or so.
Kind regards,
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
>From 03a374ee0a28128f6df8b02c64b975353a55f4ef Mon Sep 17 00:00:00 2001
From: Laura Arjona Reina <larjona@debian.org>
Date: Wed, 16 Oct 2019 14:41:04 +0200
Subject: [PATCH] remove NOCOMMENTS="yes", so the fineprint "To report a
problem with the website..." is shown in every page
---
english/consultants/index.wml | 2 +-
english/contact.wml | 2 +-
english/legal/privacy.wml | 2 +-
english/template/debian/cdimage.wml | 2 +-
english/template/debian/consultant.wml | 2 +-
english/template/debian/projectnews/header.wml | 2 +-
english/template/debian/weeklynews/header.wml | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/english/consultants/index.wml b/english/consultants/index.wml
index 74a363803a5..b5d9ed0c383 100644
--- a/english/consultants/index.wml
+++ b/english/consultants/index.wml
@@ -1,4 +1,4 @@
-#use wml::debian::template title="Consultants" NOCOMMENTS="yes" GENTIME="yes"
+#use wml::debian::template title="Consultants" GENTIME="yes"
<p>Debian is free software and offers free help through
<a href="../MailingLists/">mailing lists</a>. Some people either don't
diff --git a/english/contact.wml b/english/contact.wml
index 5bf07b283e9..a420323faa1 100644
--- a/english/contact.wml
+++ b/english/contact.wml
@@ -1,4 +1,4 @@
-#use wml::debian::template title="Getting in Contact with Us" NOCOMMENTS="yes"
+#use wml::debian::template title="Getting in Contact with Us"
<p>Debian is a large organization and there are a lot of ways to contact it.
This page will summarize the often requested means of contacting; it is by
diff --git a/english/legal/privacy.wml b/english/legal/privacy.wml
index 68cff042a11..bf300efad0e 100644
--- a/english/legal/privacy.wml
+++ b/english/legal/privacy.wml
@@ -1,4 +1,4 @@
-#use wml::debian::template title="Privacy Policy" NOCOMMENTS="yes"
+#use wml::debian::template title="Privacy Policy"
## Translators may want to add a note stating that the translation
## is only informative and has no legal value, and people
diff --git a/english/template/debian/cdimage.wml b/english/template/debian/cdimage.wml
index eebfecaaf0a..36cf15e213f 100644
--- a/english/template/debian/cdimage.wml
+++ b/english/template/debian/cdimage.wml
@@ -96,7 +96,7 @@
# for now, use the English pictures
<define-tag cdpiclang>en</define-tag>
-#use wml::debian::basic LINK="#8c4939" VLINK="#45241c" ALINK="#ff2600" NOCOMMENTS=true
+#use wml::debian::basic LINK="#8c4939" VLINK="#45241c" ALINK="#ff2600"
<div id="second-nav">
<!--UdmComment-->
diff --git a/english/template/debian/consultant.wml b/english/template/debian/consultant.wml
index ed8e4d87e27..6226507950e 100644
--- a/english/template/debian/consultant.wml
+++ b/english/template/debian/consultant.wml
@@ -9,7 +9,7 @@
<gettext domain="consultants">Back to the <a href="./">Debian consultants page</a>.</gettext>
</define-tag>
-#use wml::debian::basic SUMMARY="$(SUMMARY)" title="<consultanttitle/>" NOCOMMENTS="yes" NOCOPYRIGHT="yes"
+#use wml::debian::basic SUMMARY="$(SUMMARY)" title="<consultanttitle/>" NOCOPYRIGHT="yes"
#use wml::debian::languages
{#check_trans#}
diff --git a/english/template/debian/projectnews/header.wml b/english/template/debian/projectnews/header.wml
index fabc193d90e..8894f669b1a 100644
--- a/english/template/debian/projectnews/header.wml
+++ b/english/template/debian/projectnews/header.wml
@@ -4,4 +4,4 @@
#use wml::debian::links.tags
#use wml::debian::toc
#use wml::debian::projectnews::boilerplates
-#use wml::debian::template title="<debianprojectnews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)" NOHOMELINK="yes" BARETITLE="yes" NOCOMMENTS="yes" SUMMARY="$(SUMMARY)"
+#use wml::debian::template title="<debianprojectnews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)" NOHOMELINK="yes" BARETITLE="yes" SUMMARY="$(SUMMARY)"
diff --git a/english/template/debian/weeklynews/header.wml b/english/template/debian/weeklynews/header.wml
index 1104403cabb..8662a44344b 100644
--- a/english/template/debian/weeklynews/header.wml
+++ b/english/template/debian/weeklynews/header.wml
@@ -2,4 +2,4 @@
#use wml::debian::common_tags
#use wml::debian::ctime
#use wml::debian::links.tags
-#use wml::debian::template title="<debianweeklynews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)" NOHOMELINK="yes" BARETITLE="yes" NOCOMMENTS="yes" SUMMARY="$(SUMMARY)"
+#use wml::debian::template title="<debianweeklynews/> - <:=&spokendate('$(PUBDATE)'):>$(PAGENAME)" NOHOMELINK="yes" BARETITLE="yes" SUMMARY="$(SUMMARY)"
--
2.20.1
Reply to: