[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845297: problem in the cvs -> git conversion: commit messages truncated



Hello all

Steve McIntyre discovered that the cvs to git conversion sometimes
produces a truncated commit message.

For example looking at the commit message for
1adf8ff0d235a7f1c310fd9e4268981e80a10cab
at the end it looks truncated:
"""
    portuguese/security/2003/dsa-231.wml: 1.1 -> 1.2
    portuguese/security/2003/dsa-233.wml: 1.1 -> 1.2
    portuguese/sec
"""

Looking at the logs of the cvs2git script that we used for the test
conversion, it creates a "cvspsfile" which is given as input to the "git
cvsimport" command (via the -P option).

I've looked at the cvspsfile and it contains the message complete (not
truncated). So I think that the truncation happens inside the "git
cvsimport". I've looked at the source code of git cvsimport command and
I think that the issue is here:


https://github.com/git/git/blob/master/git-cvsimport.perl#L884
https://github.com/git/git/blob/master/git-cvsimport.perl#L885

# compatibility with git2cvs
substr($logmsg,32767) = "" if length($logmsg) > 32767;

I'll patch my local /usr/lib/git-core/git-cvsimport removing that line,
and will run a new conversion and upload it to Salsa.

If it solves the problem, we can add this to the documentation for the
final conversion "howto". (If you know better solution, just tell).

Cheers

-- 
Laura Arjona Reina
https://wiki.debian.org/LauraArjona


Reply to: