[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700570: marked as done (www.debian.org: people page shouldn't link qa page for missing emails)

Your message dated Thu, 14 Feb 2013 21:33:45 -0400
with message-id <511D9079.3070506@debian.org>
and subject line Re: Bug#700570: www.debian.org: people page shouldn't link qa page for missing emails
has caused the Debian Bug report #700570,
regarding www.debian.org: people page shouldn't link qa page for missing emails
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
700570: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700570
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: www.debian.org
Severity: minor
Tags: patch

Hi.

In the devel/people page, there are entries for developers who are listed in the LDAP as having a homepage even though they don't maintain packages.

This could be OK, even though I'm not sure of the intent... maybe to acknowledge non-packaging members... but anyway, that's not the issue.

The issue is that the script manages them by not setting an email, in which case, the qa links are incorrect.

Here's a patch that fixes this.

IMHO, it would be better, to list them with their email, and flag them in another way, so that no package list is processed.

Hope this helps.

Best regards,

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

>From 33221ab8f32820294d53e9820d3d88f97eb602a2 Mon Sep 17 00:00:00 2001
From: Olivier Berger <olivier.berger@telecom-sudparis.eu>
Date: Thu, 14 Feb 2013 13:37:10 +0100
Subject: [PATCH] Don't display the QA page link if no email set


Signed-off-by: Olivier Berger <olivier.berger@telecom-sudparis.eu>
---
 people_scripts/people.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/people_scripts/people.pl b/people_scripts/people.pl
index e04bd46..ce138bc 100755
--- a/people_scripts/people.pl
+++ b/people_scripts/people.pl
@@ -57,7 +57,7 @@ sub print_maintainer {
 		print "&nbsp;<a href=\"mailto:$People{$names}{email}\";>&lt;$People{$names}{email}&gt;</a>\n";
 	}
 	# create link to QA page
-	if (defined $People{$names}{email}) {
+	if ($People{$names}{email} ne "") {
 		my $qa = join "", $quality_assurance, $People{$names}{email};
 		print "&nbsp;(<a href=\"$qa\">QA page</a>)\n";
 	}
-- 
1.7.10.4

--- End Message ---
--- Begin Message --- 
Hi,

Le 14/02/2013 08:45, Olivier Berger a écrit :

> Here's a patch that fixes this.

Thanks, applied, the result will be online tomorrow.

> IMHO, it would be better, to list them with their email, and flag them in another way, so that no package list is processed.

It's on the TODO list to rewrite these scripts and use some new fancy
tools like UDD to produce this page, but nobody started the work AFAIK.

Regards

David

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: