[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#532535: marked as done (packages.debian.org: issues with version anchor)

Your message dated Sat, 30 Apr 2011 00:21:22 +0200
with message-id <20110429222122.GB17836@glenfiddich.mraw.org>
and subject line Re: Bug#532535: packages.debian.org: issues with version anchor
has caused the Debian Bug report #532535,
regarding packages.debian.org: issues with version anchor
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
532535: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532535
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: www.debian.org
Severity: minor
Tag: patch

Hi,

The version anchors are quite strange (on top on being hidden) :
http://packages.debian.org/changelogs/pool/main/v/vidalia/vidalia_0.1.13-1/changelog#versionversion0.1.9-1

In conf/tmpl/content.tmpl, there are two variables providing the
version in different ways, CONTENT_VERSION_ID and CONTENT_VERSION.

I don't know whether it's better to use :
<TMPL_VARNAME="CONTENT_VERSION_ID">
or version<TMPL_VAR NAME="CONTENT_VERSION">

By the way, that would be nice to make the anchor visible, under the
version.

Here is a little patch for this.

-- 
Simon Paillard

diff --git a/conf/tmpl/content.tmpl b/conf/tmpl/content.tmpl
index 693b9d4..0c85e16 100644
--- a/conf/tmpl/content.tmpl
+++ b/conf/tmpl/content.tmpl
@@ -4,9 +4,9 @@
 <TMPL_VAR NAME="CONTENT_YEAR">
 </h2>
 <TMPL_LOOP NAME="CONTENT_VERSIONS">
-<h3 class="entry_header" id="version<TMPL_VAR NAME="CONTENT_VERSION_ID">">
+<h3 class="entry_header" id="<TMPL_VAR NAME="CONTENT_VERSION_ID">">
 	<a class="packagelink" href="http://packages.debian.org/src:<TMPL_VAR ESCAPE="URL" NAME="CONTENT_SOURCE">"><TMPL_VAR NAME="CONTENT_SOURCE"></a>
-	 (<TMPL_VAR NAME="CONTENT_VERSION">)
+	 (<a href="<TMPL_VAR NAME="CONTENT_VERSION_ID">"><TMPL_VAR NAME="CONTENT_VERSION"></a>)
 	<span class="<TMPL_VAR NAME="CONTENT_DISTRIBUTION_NORM">"><TMPL_VAR NAME="CONTENT_DISTRIBUTION"></span>;
 	urgency=<span class="<TMPL_VAR NAME="CONTENT_URGENCY_NORM">"><TMPL_VAR NAME="CONTENT_URGENCY"></span>
 </h3>

--- End Message ---
--- Begin Message --- 
On Tue, Jun 09, 2009 at 11:53:24PM +0200, Simon Paillard wrote:
> Package: www.debian.org
> Severity: minor
> Tag: patch
> 
> The version anchors are quite strange (on top on being hidden) :
> http://packages.debian.org/changelogs/pool/main/v/vidalia/vidalia_0.1.13-1/changelog#versionversion0.1.9-1
> 
> In conf/tmpl/content.tmpl, there are two variables providing the
> version in different ways, CONTENT_VERSION_ID and CONTENT_VERSION.
> 
> I don't know whether it's better to use :
> <TMPL_VARNAME="CONTENT_VERSION_ID">
> or version<TMPL_VAR NAME="CONTENT_VERSION">

http://git.debian.org/?p=webwml/packages.git;a=commit;h=70a76abca0ebed885b49fd757046700e406a3fd6

Applied on powell (aka packages.debian.org master)

-- 
Simon Paillard

--- End Message ---
Reply to: