[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#262617: packages.debian.org: patch for screenshots.d.n integration



Hi web team,

I also would like to see screenshots on the p.d.o page. Conveniently,
screenshots.d.n provides a predictable URL for one screenshot thumbnail
that fits nicely into the p.d.o interface. When no screenshot is
available, an appropriate dummy is presented.

I am running the patch on
http://pkg-fso.nomeata.de/sid/mumpot
but unfortunately, none of the packages in that repository have a
screenshot.

Please consider applying the patch (which is against the master branch
of http://source.djpig.de/cgi-bin/gitweb.cgi?p=packages.git;a=summary)
on p.d.o.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
From 1dda0b50050de5f1cb8192e580554cdd1fda80ca Mon Sep 17 00:00:00 2001
From: Joachim Breitner <mail@joachim-breitner.de>
Date: Fri, 30 Jul 2010 15:43:19 +0200
Subject: [PATCH] Show screenshot from screenshots.debian.org (Closes: #262617)

---
 static/packages.css.sed.in |    4 ++++
 templates/config.tmpl      |    2 ++
 templates/html/show.tmpl   |    7 +++++++
 3 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/static/packages.css.sed.in b/static/packages.css.sed.in
index ca44350..0c24505 100644
--- a/static/packages.css.sed.in
+++ b/static/packages.css.sed.in
@@ -40,6 +40,10 @@ h1 {
 	margin-left: 1em;
 	margin-right: 1em;
 }
+#screenshot {
+        display: block;
+        text-align:center;
+}
 #pmoreinfo { 
              font-size: smaller;
              margin-left: 1em;
diff --git a/templates/config.tmpl b/templates/config.tmpl
index 85c52f7..aa1dee5 100644
--- a/templates/config.tmpl
+++ b/templates/config.tmpl
@@ -23,6 +23,8 @@
    policy_url = 'http://www.debian.org/doc/debian-policy/'
    cn_help_url = project_homepage _ 'intro/cn'
    patch_tracking_url = 'http://patch-tracker.debian.org/package'
+   screenshots_url = 'http://screenshots.debian.net/package/'
+   screenshots_thumb_url = 'http://screenshots.debian.net/thumbnail/'
    logo = {
 	url => project_homepage,
         src => '/Pics/openlogo-nd-25.png',
diff --git a/templates/html/show.tmpl b/templates/html/show.tmpl
index ec71a19..16f3146 100644
--- a/templates/html/show.tmpl
+++ b/templates/html/show.tmpl
@@ -63,6 +63,13 @@
 [% UNLESS is_virtual %]
 <div id="pmoreinfo">
 <h2>[% g('Links for %s', pkg) %]</h2>
+
+[% IF screenshots_url && screenshots_thumb_url && !is_source %]
+<a id="screenshot" href="[% screenshots_url _ pkg %]">
+<img src="[% screenshots_thumb_url _ pkg %]" alt="Screenshot" border="0"/>
+</a>
+[% END %]
+
 <h3>[% g('%s Resources:', organisation) %]</h3>
 <ul>
 <li><a href="[% (is_source ? src_bugs_url : bugs_url) _ pkg %]">[% g('Bug Reports') %]</a></li>
-- 
1.7.1

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: