Bug#120003: marked as done ([PATCH] fix to Makefile.common to support errors better)
Your message dated Sun, 2 Dec 2001 15:53:10 +0100
with message-id <20011202155310.A2779@cibalia.gkvk.hr>
and subject line Closing
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 17 Nov 2001 20:36:07 +0000
>From doogie@debian.org Sat Nov 17 14:36:07 2001
Return-path: <doogie@debian.org>
Received: from c1494421-a.alntn1.tx.home.com (yakko.doogie.org) [24.4.56.213] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 165CC7-0006fj-00; Sat, 17 Nov 2001 14:36:07 -0600
Received: from localhost [127.0.0.1] (adam)
by yakko.doogie.org with esmtp (Exim 3.32 1 (Debian))
id 165CBr-0004J6-00; Sat, 17 Nov 2001 14:35:51 -0600
Date: Sat, 17 Nov 2001 14:35:51 -0600 (CST)
From: Adam Heath <doogie@debian.org>
X-X-Sender: <adam@yakko.doogie.org>
To: <submit@bugs.debian.org>
Subject: [PATCH] fix to Makefile.common to support errors better
Message-ID: <Pine.LNX.4.33.0111171434060.10079-100000@yakko.doogie.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: submit@bugs.debian.org
Package: www.debian.org
Tags: patch
If there are errors after wml has run(ie, touch_translations.pl doesn't exist,
or perl can't fine Perl/Local/Cvsinfo.pm), then the $(WMLOUTFILE) is still
created, when it shouldn't be.
The following patch fixes this.
Index: Makefile.common
===================================================================
RCS file: /cvs/webwml/webwml/Makefile.common,v
retrieving revision 1.49
diff -u -r1.49 Makefile.common
--- Makefile.common 2001/10/31 16:37:07 1.49
+++ Makefile.common 2001/11/17 20:32:46
@@ -16,7 +16,7 @@
WMLOUTFILE = $(@F)
WMLPROLOG :=
WMLEPILOG :=
-WML = wml $(WMLOPTIONS) -o UNDEFu$(LANGUAGECAP):$(WMLOUTFILE)@g+w $(WMLPROLOG) $(WMLEPILOG)
+WML = wml $(WMLOPTIONS) -o UNDEFu$(LANGUAGECAP):$(WMLOUTFILE).new@g+w $(WMLPROLOG) $(WMLEPILOG)
WMLFILES = $(wildcard *.wml)
ifndef SUBLANG
@@ -88,6 +88,7 @@
ifneq "$(findstring /international/,$(CURDIR)/)" ""
$(WMLBASE)/../touch_translations.pl $(CURDIR)/$(<F) $(LANGUAGE)
endif
+ mv $(WMLOUTFILE).new $(WMLOUTFILE)
endif
ifndef NOGENERICINSTDEP
----BEGIN GEEK CODE BLOCK----
Version: 3.12
GCS d- s: a-- c+++ UL++++ P+ L++++ !E W+ M o+ K- W--- !O M- !V PS--
PE++ Y+ PGP++ t* 5++ X+ tv b+ D++ G e h*! !r z?
-----END GEEK CODE BLOCK-----
----BEGIN PGP INFO----
Adam Heath <doogie@debian.org> Finger Print | KeyID
67 01 42 93 CA 37 FB 1E 63 C9 80 1D 08 CF 84 0A | DE656B05 PGP
AD46 C888 F587 F8A3 A6DA 3261 8A2C 7DC2 8BD4 A489 | 8BD4A489 GPG
-----END PGP INFO-----
---------------------------------------
Received: (at 120003-close) by bugs.debian.org; 2 Dec 2001 14:51:36 +0000
>From joy@cibalia.gkvk.hr Sun Dec 02 08:51:36 2001
Return-path: <joy@cibalia.gkvk.hr>
Received: from cibalia.gkvk.hr [161.53.211.3]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 16AXxw-0000Ff-00; Sun, 02 Dec 2001 08:51:36 -0600
Received: from joy by cibalia.gkvk.hr with local (Exim 3.12 #1 (Debian))
id 16AXzS-0000j3-00
for <120003-close@bugs.debian.org>; Sun, 02 Dec 2001 15:53:10 +0100
Date: Sun, 2 Dec 2001 15:53:10 +0100
To: 120003-close@bugs.debian.org
Subject: Closing
Message-ID: <20011202155310.A2779@cibalia.gkvk.hr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
From: Josip Rodin <joy@cibalia.gkvk.hr>
Delivered-To: 120003-close@bugs.debian.org
Hi,
I'm closing the bug, for reasons mentioned before.
--
2. That which causes joy or happiness.
Reply to: