Re: Debian WWW CVS: joy

[Martin Schulze <joey@finlandia.infodrom.north.de>]

Josip Rodin wrote:
> On Tue, May 29, 2001 at 08:01:10AM +0200, Martin Schulze wrote:
> > Debian WWW CVS wrote:
> > > CVSROOT:	/cvs/webwml
> > > Module name:	webwml
> > > Changes by:	joy	01/05/28 08:24:25
> > > 
> > > Modified files:
> > > 	english        : Makefile 
> > > 
> > > Log message:
> > > erm, actually removed sitemap from index deps, and added missing deps for sitemap itself
> > 
> > You've added the calls to make to ensure that subscribe.wml and
> > unsubscribe.wml are in place.  Was that intentional?
> 
> I _have_? The Makefile says:
> 
> sitemap.$(LANGUAGE).html: $(ENGLISHDIR)/sitemap.wml \
>   $(TEMPLDIR)/links.tags.wml $(TEMPLDIR)/template.wml \
>   $(ENGLISHDIR)/releases/info $(ENGLISHDIR)/MailingLists/mklist.tags
> [three methods to build it]
> 
> What do you mean subscribe.wml and unsubscribe.wml?

I was - no shit - talking about these files without which make would
break.  They are auto-generated and thus do not exist on a new checkout.

$(ENGLISHDIR)/MailingLists/subscribe.wml
$(ENGLISHDIR)/MailingLists/unsubscribe.wml

Here's the diff that shows what I missed in detail.

-ifeq "$(LANGUAGE)" "en"
-sitemap.$(LANGUAGE).html: $(ENGLISHDIR)/sitemap.wml
-       make -C MailingLists subscribe.$(LANGUAGE).html unsubscribe.$(LANGUAGE).html
-else
-sitemap.$(LANGUAGE).html: $(ENGLISHDIR)/sitemap.wml
-       make -C MailingLists subscribe.$(LANGUAGE).html unsubscribe.$(LANGUAGE).html

Regards,

	Joey

-- 
We all know Linux is great... it does infinite loops in 5 seconds.
        -- Linus Torvalds