Bug#694077: Package review
Hi!
On Sun, 25 Aug 2019 at 06:22, Jérôme Lebleu <jerome@maroufle.fr> wrote:
>
> Le 24/08/2019 à 22:26, Lisandro Damián Nicanor Pérez Meyer a écrit :
> > please release it (dch -r), push it and I'll upload.
>
> It is now done and pushed, thanks in advance!
>
> I tried again to build the package and didn't have any failure this
> time. The one that didn't pass was at this line:
>
>
> https://github.com/mcallegari/qlcplus/blob/QLC+_4.12.1/engine/test/mastertimer/mastertimer_test.cpp#L197
>
> We will see if this test fails on the Debian build system too. In that
> case, we will maybe have to add DEFINES+=SKIP_TEST as it is done when
> travis is used:
>
>
> https://github.com/mcallegari/qlcplus/blob/QLC%2B_4.12.1/engine/test/mastertimer/mastertimer.pro#L18
>
> I should ask Massimo in that case since this variable name can be ambiguous.
Mmm, I'm not entirely sure if the code in plugins/hid is
DFSG-compliant. It's license it's too lax. I think I'll upload it non
the less in the meantime, and see what FTP masters think.
--
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
Reply to: