[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#872355: ITP: node-is-module -- Node.js code to check if a string is an ES6 module



Julien Puydt <julien.puydt@laposte.net> writes:

> Hi,
>
> Le 16/08/2017 à 19:26, Philip Hands a écrit :
>> Julien Puydt <julien.puydt@laposte.net> writes:
>>> * URL             : https://github.com/component/is-module
>> 
>> That URL is not correct.
>> 
>> Did you perhaps mean:  https://github.com/timaschew/is-module
>> 
>
> It's annoying:
>    https://www.npmjs.com/package/is-module
> points to:
>    https://github.com/component/is-module
> so what I packaged is what people using npm to get their javascript
> chunk actually use. But indeed, that link is a 404.
>
> The link you point to gives the same license with the same copyright,
> but it doesn't look like it's the same author, so I don't know what
> I'm supposed to do.

Sorry, I've no idea -- the link I came up with is just the result of
putting 'is-module' into github's search -- I have no information about
how that might relate to whatever was at the other link, or why it's not
there now.

I do note that timaschew's version includes a comment:

  // no idea what these regular expressions do,
  ...

  ( https://github.com/timaschew/is-module/blob/master/index.js#L2 )

which strikes me as a little worrying, given that the regular
expressions constitute pretty-much everything that this package does, so
if you can find a version of this by someone that knows what they are
doing, that might be a bonus ;-)

I guess that the way to make that better would be to get the person
responsible for the original version of the regexps to factor that bit
out into a separate library, and then rely on that in their code, at
which point you'd have a maintained version of the regexps to use, but I
can understand that that might not be the path of least resistance.

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

Attachment: signature.asc
Description: PGP signature


Reply to: