Re: questions regarding patch-src

[frank@kuesterei.ch (Frank Küster)]

Florent Rougon <f.rougon@free.fr> schrieb:

> Re-hi,
>
> frank@kuesterei.ch (Frank Küster) wrote:
>
>> **************
>> * texk/web2c/pdftexdir/writefont.c
>>
>> In this file we add the line 
>>
>> #include "../../../libs/xpdf/goo/gmem.h"  /* gmalloc() */
>>
>> However, as I said the upstream sources compile fine in sid (I didn't
>> try yet to dpkg-buildpackage). 
>
> The comment suggests that the include was added so that the prototype of
> the gmalloc function be known by the C compiler when compiling this
> module, and there is no gmalloc call in the writefont.c from
> tetex-bin-2.0.2 (the version in unstable). If there is no such call in
> your version, it is probably safe to remove the include line.

I'll simply try it out - if it causes problems while compiling for the
Debian package I'll find out.

>> return 1 ; /* note:  there *is* no unsuccessful return */
>>
>> This is the case both in 2.0.2 and in the beta version (2.95.0). So it
>> does return a boolean, doesn't it?
>
> Most probably.
>
> /tmp/tetex-bin-2.0.2 % grep "typedef.*boolean" **/*.h           sid flo@florent
> libs/type1/util.h:typedef int boolean;
> texk/dvipdfm/pdfobj.h:typedef struct pdf_boolean pdf_boolean;
> texk/dvipsk/dvips.h:typedef char boolean;
> texk/kpathsea/types.h:typedef int boolean;
> texk/ps2pkm/util.h:typedef int boolean;
> texk/web2c/cwebdir/common.h:typedef short boolean;

I don't understand this (I never learned to program in C). This defines
the type boolean as the same as the first argument to typedef, right?
But there is a type boolean in standard C, isn't it? So why the
redefinition? And what effect does the redefinition have? 

In writet1.c, I find the following:

#ifdef pdfTeX /* writet1 used with pdfTeX */
[...]
#else /* writet1 used with dvips */
#include "ptexmac.h"
#include "dvips.h"

(and there is only the dvips.h that your grep command found). So does
this mean anything - should the declaration of t1_subset be dependent on
whether we compile for pdfTeX or for dvips? On the other hand, this
writet1.c seems to be used only for pdftex, since it is in
texk/web2c/pdftexdir/, and dvips has it's own in /texk/dvips/

TIA, Frank
-- 
Frank Küster, Biozentrum der Univ. Basel
Abt. Biophysikalische Chemie