Re: Bug#225004: tetex-extra: Type1 fonts should be in a separate package

[frank@kuesterei.ch (Frank Küster)]

Florent Rougon <f.rougon@free.fr> schrieb:

>>> grep -E '\.(afm|pfb)$$'
>>
>> What's the second $ for?
>
> Make will eat it (remember debian/rules is a Makefile...).

You should rather have said "remember we are talking about commands in
debian/rules"... 

>>> +	sort debian/tetex-extra.files debian/tetex-extra-fonts.files | uniq -u > tetex-extra.tmp
>>> +	mv -f tetex-extra.tmp debian/tetex-extra.files
>>>
>>> IMHO, debian/tetex-extra-fonts.files has nothing to do here. I think you
>>> wanted to uniq -u tetex-extra-fonts.files for fear of files listed
>>> several times, but this is not was is performed.
>>
>> He's taking out the contents of tetex-extra-fonts.files from
>> tetex-extra.files. One could of course use grep -v, like above.
>
> Perhaps he's meaning to do so, but he's not doing so. At the time the
> sort is performed, tetex-extra-fonts.files is a subset of
> tetex-extra.files. Having them both as arguments to the sort is no
> different than having only tetex-extra.files. tetex-extra.files will get
> sorted and uniq'ed, great. That's all. Or am I mistaken?

You are, in this case:

~$ cat > files.all
eins
zwei
~$ cat > files.selected
eins
~$ sort files.all files.selected 
eins
eins
zwei
~$ sort files.all files.selected | uniq -u
zwei
~$ 

Still I agree that 

+# now split off Type1-files
+	grep -E '\.(afm|pfb)$$' debian/tetex-extra.files > debian/tetex-extra-fonts.files
+       grep -Ev '\.(afm|pfb)$$' debian/tetex-extra.files > tetex-extra.tmp
+	mv -f tetex-extra.tmp debian/tetex-extra.files

is probably clearer. By the way we don't create these tempfiles in a
save way. I cannot judge if this is a problem here.

Regards, Frank
-- 
Frank Küster, Biozentrum der Univ. Basel
Abt. Biophysikalische Chemie