Re: ALSA Driver for Sparc DBRI chips
On Tue, Nov 23, 2004 at 05:54:05PM +0100, Hendrik Sattler wrote:
> Am Dienstag, 23. November 2004 16:26 schrieb Martin Habets:
> > In my 2.6.8 kernel build I do have asm/asm_offsets.h with at the top:
> > * This file was generated by arch/sparc/Makefile
> > and then a bunch of AOFF_* defines.
> >
> > My recommendation would be either to upgrade kernel-headers, or just
> > comment out the include.
>
> Already found that out. As you can see, I use 2.4.27 and thus, I should not
> use 2.6.x kernel header files.
> I'll file a bug report against kernel-headers-2.4.27-1 since auto builders
> cannot do that change. Another work-around is to simple touch the missing
> header file.
As this is a new driver (well, kind of), I was planning on testing/submitting
it for 2.6 first and backport it later if needed. I have not done any 2.4
testing myself.
> > > > At: http://www.mph.eclipse.co.uk/pub/linux/dbri
> > > > you'll find these files:
> > > > - dbri.c Source code of the driver
> > > > - Alsa.patch Patch against Alsa-driver 1.0.7rc1, without the driver
> > > > code itself (pick up dbri.c and put it in
> > > > alsa-kernel/sparc).
> > >
> > > That patch is incomplete: alsa-driver/acinclude.m4 needs to be modified
> > > and aclocal and autoconf must be run afterwards, so that the configure
> > > option --with-cards=sun-dbri
> > > is usable. Just take AMD7930 as example and make a simple copy and
> > > modify.
> >
> > Actually, acinclude.m4 is generated by 'make all-deps' (which should also
> > recompile util/mod-deps).
>
> I manually do now:
> cp ../sbri.c alsa-kernel/sparc/
> patch -p1 < ../Alsa.patch
> #mod-deps binary is not the right one for sparc
> rm utils/mod-deps
> #create updated acinclude.m4
> make all-deps
> #create updated aclocal.m4 (probably optional)
> aclocal
> #create updated configure
> autoconf
> ./configure --with-oss=no --with-cards=sun-amd7930,sun-dbri
> make
Good to see that is working now.
> I cannot compile in the OSS compatibility layer because the Debian Sparc
> kernels do not have the proper option enabled :-(
>
> However, I must tell you that compilation of the driver fails:
Looks like a gcc thing. I can reproduce the error you are getting on gcc-3.3
but not on gcc-2.95. With the patch below it builds for both versions.
Thanks!
--
Martin
--- dbri.c1 2004-11-23 22:42:11.313925868 +0000
+++ dbri.c 2004-11-23 22:42:27.085915224 +0000
@@ -100,7 +100,7 @@
};
#ifdef DBRI_DEBUG
-#define dprintk(a, x...) if(dbri_debug & a) snd_printd(KERN_DEBUG ## x)
+#define dprintk(a, x...) if(dbri_debug & a) snd_printd(KERN_DEBUG x)
#define DBRI_CMD(cmd, intr, value) ((cmd << 28) | \
(1 << 27) | \
Reply to: