[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fix for bridge-utils for Sparc64



On Thu, 2004-04-08 09:48:19 -0400, Small, Jim <jim.small@eds.com>
wrote in message <[🔎] 564DE4477544D411AD2C00508BDF0B6A1ED3BE41@USAHM018.amer.corp.eds.com>:
> Here is a diff too:
> # diff -Nru bridge-utils/libbridge/libbridge_devif.c
> bridge-utils/libbridge/libbridge_devif.c.orig 
> --- bridge-utils/libbridge/libbridge_devif.c    2004-04-01
> 21:10:55.000000000 -0500
> +++ bridge-utils/libbridge/libbridge_devif.c.orig       2002-01-16
> 07:04:45.000000000 -0500

You reversed the diff and your email client mangled it, too...

> @@ -56,7 +56,7 @@
>         memcpy(ifr.ifr_name, br->ifname, IFNAMSIZ);
>         ((unsigned long long *)(&ifr.ifr_data))[0] = (unsigned long
> long)(unsigned long)args;
>  
> -       return ioctl(br_socket_fd, SIOCDEVPRIVATE, &ifr);
> +       return ioctl(br_socket_fd, SIOCDEVPRIVATE + 3, &ifr);
>  }
>  #endif
> 

Just adding or removing some magic constants isn't good. If there's
something missing on the kernel side, just fix it there.

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature


Reply to: