Re: kernel-package sparc confusion

[Ben Collins <bcollins@debian.org>]

This looks good, except that checking the filter for sparc64% and equal
to sparc64 is redundant. The only reason for it is to detect things like
sparc64-smp, which will match the filter just like sparc64 will. So
something like this:

ifneq (,$(filter sparc64%,$(KPKG_SUBARCH)))
  KERNEL_ARCH = sparc64
else
  ifneq (,$(filter sparc%,$(KPKG_SUBARCH)))
    KERNEL_ARCH = sparc
  else
    KERNEL_ARCH = $(strip $(shell uname -m))
  endif
endif

So the logic speaks, if it starts with sparc64, make it that. If it
starts with sparc, make it just sparc, otherwise fallback on uname -m.
This is for people that like doing subarch=ultrasparcIII or something.

>  ifneq (,$(filter sparc64%,$(KPKG_SUBARCH)))
> -KERNEL_ARCH = sparc64
> + KERNEL_ARCH = sparc64
>  else
> -  ifeq ($(KPKG_SUBARCH),sparc64)
> -  KERNEL_ARCH = sparc64
> + ifeq ($(KPKG_SUBARCH),sparc64)
> + KERNEL_ARCH = sparc64
> + else
> +  ifneq (,$(filter sparc32%,$(KPKG_SUBARCH)))
> +   KERNEL_ARCH = sparc
>    else
> +   ifeq ($(KPKG_SUBARCH),sparc32)
> +    KERNEL_ARCH = sparc
> +   else
>      KERNEL_ARCH = $(strip $(shell uname -m))
> -    ifneq (,$(filter sparc%,$(KPKG_SUBARCH)))
> -      KERNEL_ARCH = sparc
> -    else
> -      KPKG_SUBARCH = sparc64
> -    endif
> +   endif
>    endif
> + endif
>  endif
>  
>  ifneq ($(shell if [ $(VERSION) -ge 2 -a $(PATCHLEVEL) -ge 5 -a  \

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/