Re: [Secure-testing-commits] r16971 - bin
Johnathan Ritzi wrote:
> How's this?
>
> Index: doc/narrative_introduction
> ===================================================================
> --- doc/narrative_introduction (revision 16973)
> +++ doc/narrative_introduction (working copy)
> @@ -441,9 +441,16 @@
> There is a script running, which automatically commits them to DSA/list.
> In some cases it needs manual fixups.
>
> -Checking your changes
> ----------------------
> +Checking in your changes
> +------------------------
>
> +After thoroughly researching each issue and editing the relevant files,
> +commit your changes. Peer review is done via the mailing list and IRC
> +notifications (see "Automatic Issue Updates" above). However, changes to
> +the tracker website itself (e.g. the files in bin/) should be vetted and
> +approved before being committed. The preferred way to do this is to send
> +a patch to the debian-security-tracker@lists.debian.org mailing list.
> +
> Commits are checked for syntax errors before they are actually committed,
> and you'll receive an error and your commit is aborted if it is in error.
> To check your changes yourself beforehand, use "make check-syntax" from
You may want to mention what "thoroughly" means; i.e. summarize [0] as
currently mentioned in the "processing todo entries" section now. You
can go ahead with the commits as you get them done, and we'll fix them
up if we see issues.
Best wishes,
Mike
Reply to: