[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: pre-commit hook to check syntax



* Thijs Kinkhorst:

>                 svnlook cat -t "$TXN" "$REPOS" "$file" > $tmpfile
> 		cd /home/groups/secure-testing/repo
>                 python bin/check-syntax CVE $tmpfile

I could change check-syntax so that it can read the data from standard
input.  This might eliminate the need for a temporary file.

I suppose the /home/groups/secure-testing/repo working copy is not
updated automatically.  I'm not sure what the consequences are when
any committer can execute arbitrary code on alioth.

> rm -f $tmpfile

I think you should use trap here.



Reply to: