[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-rack-accept



On Sunday 22 December 2013 01:14 PM, Praveen A wrote:
> 2013/7/11 Nitesh A Jain <niteshjain92@gmail.com>:
>> Hi,
>>
>> I prepared the packaging of ruby-rack-accept. It is lintian clean
>> and tested with pbuilder. Further information about this package can
>> be accessed from the URL
>>
>> http://mentors.debian.net/package/ruby-rack-accept
>>
>>  Alternatively, one can download the package with dget using this command:
>>
>>     dget -x http://mentors.debian.net/debian/pool/main/r/ruby-rack-accept/ruby-rack-accept_0.4.5-1.dsc
>>
>> I have pushed the package to the team repo and it can be found here:
>>
>> http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-rack-accept.git
>>
>> Consider to review and upload it.
>>
>> Regards,
>> Nitesh A Jain
> 
> Hi Nitesh,
> 
> Thanks for your work. Some small comments.

Thank you for the review

> 1. It has a dependency on rack >= 0.4 but it is left commented out.
> Since you have added it to build depends, you can remove that comment
> line.
I have removed the commented line
> 2. In the description, leave a space after full stop.

Done
> Otherwise the package seems ready. I'll upload once you make these changes.

I have pushed the changes

> Praveen
> 


Nitesh Jain

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: