[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#979072: RM: pepperflashplugin-nonfree -- RoQA; No longer work; upstream eol



On 1/16/21 7:54 PM, Adam D. Barratt wrote:
> On Fri, 2021-01-15 at 18:48 +0100, Andreas Beckmann wrote:
>> I think it would be better to replace the broken installer package
>> with
>> a dummy package stating the EoL fact. (see #978954 for more
>> discussion)

> Do you have a proposed diff for such an upload?

Of course ;-)

It comes with a debhelper bump and some packaging improvements, but I 
decided to keep them since the resulting dummy binary package has not 
much in common with the package currently in buster anyway (see binary
debdiff below).

Installing the current package in a buster chroot is a bit tricky,
since wget seems to have a long timeout, I finally had to kill it
(this does not fail the installation).
Upgrading to the proposed package is smooth:

buster# apt-get install /tmp/pepperflashplugin-nonfree_1.8.8~deb10u1_amd64.deb 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Note, selecting 'pepperflashplugin-nonfree' instead of '/tmp/pepperflashplugin-nonfree_1.8.8~deb10u1_amd64.deb'
The following packages will be REMOVED:
  gnupg1 libcurl3-gnutls libldap-2.4-2 libldap-common libnghttp2-14 libnspr4 libnss3 libpcre2-8-0 libpsl5 librtmp1 libssh2-1 libxt6 wget
The following packages will be upgraded:
  pepperflashplugin-nonfree
1 upgraded, 0 newly installed, 13 to remove and 0 not upgraded.
Need to get 0 B/6032 B of archives.
After this operation, 11.9 MB disk space will be freed.
Do you want to continue? [Y/n] 
Get:1 /tmp/pepperflashplugin-nonfree_1.8.8~deb10u1_amd64.deb pepperflashplugin-nonfree amd64 1.8.8~deb10u1 [6032 B]
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 76, <> line 1.)
debconf: falling back to frontend: Readline
(Reading database ... 23565 files and directories currently installed.)
Preparing to unpack .../pepperflashplugin-nonfree_1.8.8~deb10u1_amd64.deb ...
Unpacking pepperflashplugin-nonfree (1.8.8~deb10u1) over (1.8.4) ...
(Reading database ... 23564 files and directories currently installed.)
Removing gnupg1 (1.4.23-1) ...
Removing libcurl3-gnutls:amd64 (7.64.0-4+deb10u1) ...
Removing libldap-2.4-2:amd64 (2.4.47+dfsg-3+deb10u4) ...
Removing libldap-common (2.4.47+dfsg-3+deb10u4) ...
Removing libnghttp2-14:amd64 (1.36.0-2+deb10u1) ...
Removing libnss3:amd64 (2:3.42.1-1+deb10u3) ...
Removing libnspr4:amd64 (2:4.20-1) ...
Removing wget (1.20.1-1.1) ...
Removing libpcre2-8-0:amd64 (10.32-5) ...
Removing libpsl5:amd64 (0.20.2-2) ...
Removing librtmp1:amd64 (2.4+20151223.gitfa8646d.1-2) ...
Removing libssh2-1:amd64 (1.8.0-2.1) ...
Removing libxt6:amd64 (1:1.1.5-1+b3) ...
Setting up pepperflashplugin-nonfree (1.8.8~deb10u1) ...
Removing obsolete conffile /etc/chromium.d/pepperflashplugin-nonfree ...
Processing triggers for libc-bin (2.28-10) ...

$ debdiff --controlfiles ALL pepperflashplugin-nonfree_1.8.4_amd64.deb pepperflashplugin-nonfree_1.8.8~deb10u1_amd64.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rwxr-xr-x  root/root   DEBIAN/preinst

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /etc/chromium.d/pepperflashplugin-nonfree
-rw-r--r--  root/root   DEBIAN/conffiles

Control files: lines which differ (wdiff format)
------------------------------------------------
[-Conflicts: chromium (<< 37.0.2062.120-4), libflash-mozplugin-]
[-Depends: binutils, debconf | debconf-2.0, gnupg1 | gnupg, libatk1.0-0, libcairo2, libcurl3-gnutls, libfontconfig1, libfreetype6, libgcc1, libglib2.0-0, libgtk2.0-0 (>= 2.14), libnspr4, libnss3, libpango-1.0-0 | libpango1.0-0, libstdc++6, libx11-6, libxext6, libxt6, wget-]
 [-This package will download Pepper-] {+(dummy package)+}
{+ The Adobe+} Flash Player [-from Adobe website,-] {+is EoL+} and
 [-configure Chromium to use it.-] {+no longer available for download.+}
 [-The end user license agreement-]
 {+This package+} is [-available at Adobe.-] {+now a dummy package taking care of the removal of a+}
{+ previously installed Pepper Flash Player plugin. It can be safely removed.+}
Homepage: [-http://wiki.debian.org/PepperFlashPlayer-] {+https://wiki.debian.org/PepperFlashPlayer+}
Installed-Size: [-29-] {+26+}
[-Pre-Depends: ca-certificates-]
[-Suggests: chromium, ttf-dejavu, ttf-mscorefonts-installer, ttf-xfree86-nonfree-]
Version: [-1.8.4-] {+1.8.8~deb10u1+}

Postinst files: lines which differ (wdiff format)
-------------------------------------------------
        update-pepperflashplugin-nonfree [---install --fast-] {+--uninstall+} || true
{+# Automatically added by dh_installdeb/12.1.1+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium.d/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium-browser/customizations/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+# End automatically added section+}

Postrm files: lines which differ (wdiff format)
-----------------------------------------------
{+# Automatically added by dh_installdeb/12.1.1+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium.d/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium-browser/customizations/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+# End automatically added section+}

Prerm files: lines which differ (wdiff format)
----------------------------------------------
{+# Automatically added by dh_installdeb/12.1.1+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium.d/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+dpkg-maintscript-helper rm_conffile /etc/chromium-browser/customizations/pepperflashplugin-nonfree 1.8.8\~ -- "$@"+}
{+# End automatically added section+}

(The second rm_conffile line is for Ubuntu)

Andreas
diff --git a/debian/changelog b/debian/changelog
index e6cd115..f061e9a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,52 @@
+pepperflashplugin-nonfree (1.8.8~deb10u1) buster; urgency=medium
+
+  * QA upload.
+  * Rebuild for buster.
+
+ -- Andreas Beckmann <anbe@debian.org>  Sun, 17 Jan 2021 16:54:21 +0100
+
+pepperflashplugin-nonfree (1.8.8) unstable; urgency=medium
+
+  * QA upload.
+  * Adobe Flash Player has reached End-of-Life and is no longer functional or
+    available for download:
+    https://www.adobe.com/products/flashplayer/end-of-life.html
+  * Turn into a dummy package taking care of removing the previously installed
+    plugin.  (Closes: #979689) (LP: #1911463)
+  * Remove download and install functionality.
+  * Remove chromium integration.
+
+ -- Andreas Beckmann <anbe@debian.org>  Fri, 15 Jan 2021 16:47:39 +0100
+
+pepperflashplugin-nonfree (1.8.7) unstable; urgency=medium
+
+  * QA upload.
+  * Hard-code libgcc-s1 instead of libgcc1.
+
+ -- Matthias Klose <doko@debian.org>  Thu, 18 Jun 2020 13:15:20 +0200
+
+pepperflashplugin-nonfree (1.8.6) unstable; urgency=medium
+
+  * QA upload.
+  * binutils is dropped from Depends by accident
+
+ -- Shengjing Zhu <zhsj@debian.org>  Mon, 13 Apr 2020 00:31:51 +0800
+
+pepperflashplugin-nonfree (1.8.5) unstable; urgency=medium
+
+  * QA upload.
+  * Remove most outdated libraries Depends, and move wget to Pre-Depends
+    libpepflashplayer.so is almost static linked.
+  * Use global wgetoptions when fetching upstream version
+  * Fix lintian: package-uses-deprecated-debhelper-compat-version
+  * Fix lintian: ancient-standards-version
+  * Fix lintian: homepage-field-uses-insecure-uri
+  * Fix lintian: rules-requires-root-missing
+  * Fix lintian: file-contains-trailing-whitespace
+  * Fix lintian: no-dep5-copyright
+
+ -- Shengjing Zhu <zhsj@debian.org>  Mon, 13 Apr 2020 00:22:32 +0800
+
 pepperflashplugin-nonfree (1.8.4) unstable; urgency=medium
 
   * QA upload.
diff --git a/debian/compat b/debian/compat
deleted file mode 100644
index ec63514..0000000
--- a/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-9
diff --git a/debian/control b/debian/control
index de87846..f3e0b0a 100644
--- a/debian/control
+++ b/debian/control
@@ -3,48 +3,20 @@ Section: contrib/web
 Priority: optional
 Maintainer: Debian QA Group <packages@qa.debian.org>
 Build-Depends:
- debhelper (>= 9),
-Standards-Version: 3.9.8
-Homepage: http://wiki.debian.org/PepperFlashPlayer
+ debhelper-compat (= 12),
+Standards-Version: 4.5.0
+Homepage: https://wiki.debian.org/PepperFlashPlayer
 Vcs-Browser: https://salsa.debian.org/debian/pepperflashplugin-nonfree
 Vcs-Git: https://salsa.debian.org/debian/pepperflashplugin-nonfree.git
+Rules-Requires-Root: no
 
 Package: pepperflashplugin-nonfree
 Architecture: amd64 i386
 Depends:
- binutils,
- debconf | debconf-2.0,
- gnupg1 | gnupg,
- libatk1.0-0,
- libcairo2,
- libcurl3-gnutls,
- libfontconfig1,
- libfreetype6,
- libgcc1,
- libglib2.0-0,
- libgtk2.0-0 (>= 2.14),
- libnspr4,
- libnss3,
- libpango-1.0-0 | libpango1.0-0,
- libstdc++6,
- libx11-6,
- libxext6,
- libxt6,
- wget,
  ${misc:Depends},
  ${shlibs:Depends},
-Pre-Depends:
- ca-certificates,
-Suggests:
- chromium,
- ttf-dejavu,
- ttf-mscorefonts-installer,
- ttf-xfree86-nonfree,
-Conflicts:
- chromium (<< 37.0.2062.120-4),
- libflash-mozplugin,
-Description: Pepper Flash Player - browser plugin
- This package will download Pepper Flash Player from Adobe website, and
- configure Chromium to use it.
+Description: Pepper Flash Player - browser plugin (dummy package)
+ The Adobe Flash Player is EoL and no longer available for download.
  .
- The end user license agreement is available at Adobe.
+ This package is now a dummy package taking care of the removal of a
+ previously installed Pepper Flash Player plugin. It can be safely removed.
diff --git a/debian/copyright b/debian/copyright
index e2630c4..24f32eb 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,27 +1,20 @@
-This package was put together by Bart Martens <bartm@knars.be> on
-Sun, 07 Jul 2013 22:52:06 +0200.
-
-Copyright:
-
-   Copyright (C) 2006-2014 Bart Martens <bartm@knars.be>
-
-License:
-
-   This program is free software: you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation, either version 3 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-On Debian systems, the complete text of the GNU General Public License
-version 3 can be found in `/usr/share/common-licenses/GPL-3'.
-
-Note that this package does not contain any software from Adobe nor from
-Google.
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Comment:
+ Note that this package does not contain any software from Adobe nor from
+ Google.
+
+Files: *
+Copyright: 2006-2014 Bart Martens <bartm@knars.be>
+License: GPL-3+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ On Debian systems, the complete text of the GNU General Public License
+ version 3 can be found in `/usr/share/common-licenses/GPL-3'.
diff --git a/debian/install b/debian/install
index 948fc42..3cca506 100644
--- a/debian/install
+++ b/debian/install
@@ -1,2 +1 @@
-debian/etc/chromium.d/pepperflashplugin-nonfree etc/chromium.d/
 update-pepperflashplugin-nonfree usr/sbin/
diff --git a/debian/maintscript b/debian/maintscript
new file mode 100644
index 0000000..4cdfe78
--- /dev/null
+++ b/debian/maintscript
@@ -0,0 +1,2 @@
+rm_conffile /etc/chromium.d/pepperflashplugin-nonfree 1.8.8~
+rm_conffile /etc/chromium-browser/customizations/pepperflashplugin-nonfree 1.8.8~
diff --git a/debian/postinst b/debian/postinst
index f7c7051..5e7a924 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -4,7 +4,7 @@ set -e
 
 case "$1" in
     configure)
-	update-pepperflashplugin-nonfree --install --fast || true
+	update-pepperflashplugin-nonfree --uninstall || true
 	# Clean up the old Google debs as we are now using Adobe tar.gz files.
 	rm -rf /var/cache/pepperflashplugin-nonfree/*.deb
 	rm -rf /var/cache/pepperflashplugin-nonfree/latest-stable-verified.txt
diff --git a/debian/rules b/debian/rules
index edfc650..31c1c17 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,4 +4,3 @@
 
 %:
 	dh $@
-
diff --git a/update-pepperflashplugin-nonfree b/update-pepperflashplugin-nonfree
index b44cc4a..e5de6d8 100755
--- a/update-pepperflashplugin-nonfree
+++ b/update-pepperflashplugin-nonfree
@@ -89,14 +89,6 @@ done
 
 [ "$verbose" != "yes" ] || echo "options : $getopt_temp"
 
-wgetquiet='-q'
-wgetfast='-t 3 -T 15'
-wgetprogress='-v --progress=dot:default'
-[ "$quiet" != "no" ] || wgetquiet=""
-[ "$fast" != "no" ] || wgetfast=""
-[ "$verbose" != "no" ] || wgetprogress=""
-wgetoptions="$wgetquiet $wgetfast $wgetprogress"
-
 arch=""
 case $(dpkg --print-architecture) in
 	amd64)	arch="x86_64" ;;
@@ -116,7 +108,7 @@ then
 		installed=$(strings /usr/lib/pepperflashplugin-nonfree/libpepflashplayer.so | awk '/LNX/{gsub(/,/,".");print$2}')
 	fi
 	[ "$verbose" != "yes" ] || echo "getting version of upstream"
-	upstream=$(HOME=/root wget -q -O- "https://get.adobe.com/flashplayer/webservices/json/?platform_type=Linux&platform_arch=$arch&browser_dist=Chrome"; | tr , '\n' | awk -F: '/"[Vv][Ee][Rr][Ss][Ii][Oo][Nn]":/{gsub(/ *",*/,"",$2);print$2;exit}')
+	upstream=None
 	[ "$upstream" != "" ] || die_hard "failed to determine upstream version"
 fi
 
@@ -125,37 +117,8 @@ case "$ACTION" in
 	--install)
 		[ "$verbose" != "yes" ] || echo "selected action = $ACTION"
 
-		if [ "$upstream" != "" ] && [ "$installed" != "" ] && [ "$upstream" = "$installed" ]
-		then
-
-			[ "$verbose" != "yes" ] || echo "upstream version $upstream is already installed"
-
-		else
-			cached=""
-			if [ -f /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so ] && [ -f /var/cache/pepperflashplugin-nonfree/manifest.json ]
-			then
-				cached=$(strings /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so | awk '/LNX/{gsub(/,/,".");print$2}')
-			fi
-			if [ "$cached" != "" ] && [ "$cached" = "$upstream" ]
-			then
-				[ "$verbose" != "yes" ] || echo "using /var/cache/pepperflashplugin-nonfree copies"
-				install -m 644 /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so /usr/lib/pepperflashplugin-nonfree/
-				install -m 644 /var/cache/pepperflashplugin-nonfree/manifest.json /usr/lib/pepperflashplugin-nonfree/
-			else
-				url="https://fpdownload.adobe.com/pub/flashplayer/pdc/$upstream/flash_player_ppapi_linux.$arch.tar.gz";
-				[ "$verbose" != "yes" ] || echo "downloading from $url"
-				mkdir -p /var/cache/pepperflashplugin-nonfree
-				HOME=/root wget $wgetoptions -O- "$url" | tar -xz -C /var/cache/pepperflashplugin-nonfree libpepflashplayer.so manifest.json
-				chown root:root /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so
-				chmod 644 /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so
-				chown root:root /var/cache/pepperflashplugin-nonfree/manifest.json
-				chmod 644 /var/cache/pepperflashplugin-nonfree/manifest.json
-				cached=$(strings /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so | awk '/LNX/{gsub(/,/,".");print$2}')
-				[ "$cached" = "$upstream" ] || die_hard "failed to download expected version $upstream, downloaded $cached"
-				install -m 644 /var/cache/pepperflashplugin-nonfree/libpepflashplayer.so /usr/lib/pepperflashplugin-nonfree/
-				install -m 644 /var/cache/pepperflashplugin-nonfree/manifest.json /usr/lib/pepperflashplugin-nonfree/
-			fi
-		fi
+		echo "The Adobe Flash Player is EoL and no longer available for download:"
+		echo "https://www.adobe.com/products/flashplayer/end-of-life.html";
 
 		[ "$verbose" != "yes" ] || echo "end of action $ACTION"
 		;;

Reply to: