Bug#880037: stretch-pu: package dput-ng/1.13
Control: tags -1 + moreinfo
Thanks for looking at fixing these bugs in stable. Unfortunately, I'm
not happy to approve the diff as-is; specific comments below.
On Sat, 2017-10-28 at 19:36 +0100, Miguel Landaeta wrote:
> +dput-ng (1.15+deb9u1) stretch; urgency=medium
That would make the package version in stretch higher than the version
in unstable.
> + [ Miguel Landaeta ]
> + * Team upload.
> + * New upstream stable release.
> +
> + [ Mattia Rizzolo ]
> + * Fix typo on the jessie-backports-sloppy target. (Closes:
> #867245)
I'm not convinced that's actually relevant for the changelog of this
package, given that the typo was never included in a package in stable.
> + * Include 'testing' in the rm-managed suites.
> + * Add jessie-backports-sloppy and stretch-backports. (Closes:
> #878665)
These sound fine.
> + * Mark dput-ng-doc as Multi-Arch:foreign.
> + * wrap-and-sort.
> + * Bump Standards-Version to 4.0.0, no changes needed.
These, however, do not. The first and last are not appropriate for a
stable update, and the wrap-and-sort produces more noise in the diff
than the actual changes.
> + * doc/man: fix some spelling errors.
> +
> + [ James Clarke ]
> + * Add ports-master profile. (Closes: #855154)
> +
> + [ Stephan Sürken ]
> + * dput/uploaders/ftp.py: Parse and use optional [:port] part for
> fqdn.
> + (Closes: #814440)
Those look OK.
What's this change about, which doesn't appear to be mentioned in the
changelog?
--- dput-ng-1.13/tests/fake_package/fnord_1.0.dsc 2017-05-30 17:41:14.000000000 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0.dsc 1970-01-01 01:00:00.000000000 +0100
...
--- dput-ng-1.13/tests/fake_package/fnord_1.0_source.changes 2017-05-30 17:41:14.000000000 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.changes 1970-01-01 01:00:00.000000000 +0100
...
--- dput-ng-1.13/tests/fake_package/fnord_1.0_source.test.upload 2017-05-30 17:41:14.000000000 +0100
+++ dput-ng-1.15+deb9u1/tests/fake_package/fnord_1.0_source.test.upload 1970-01-01 01:00:00.000000000 +0100
Regards,
Adam
Reply to: