Bug#854520: unblock: chrony/3.0-3
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Dear release team,
Please unblock package chrony
This update solves #854424¹ (severity important) which affect chrony 3.0
(an NTP implementation.) This issue occurs when using the time smoothing
process in interleaved mode and have the nasty effect of decreasing the
timestamps accuracy… which is precisely what interleaved modes should
improve. I left technical information in the bug report to avoid making
that unblock request indigestible, but the proposed fix is quite easy to
review (2 lines); it just consists in including the smoothing offset in
the updated server's transmit timestamp.
The proposed update has been uploaded (thanks to Paul Gevers) and built
successfully on all applicable architectures. Source debdiff attached!
unblock chrony/3.0-3
Cheers,
Vincent
¹https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854424
-----BEGIN PGP SIGNATURE-----
iQJLBAEBCgA1FiEE/VQBlxWoTJPh4vI5ipzudlpxp4AFAliaUb0XHHZpbmNlbnQu
ZGViaWFuQGZyZWUuZnIACgkQipzudlpxp4AkHhAAu4EAEexXiA/56KHGo1uhK+D4
tod6rXONWSfj4HU8tWr7G1C83D2fkOLyCOYrVniHK0QiW5EiCwGR2yjEhA8QPvar
Ynaantb00iTrTgkAsj2S57qtNqve8+jaD9fmHgtpZZeYdtLjTLkYUmfRuGqb3d35
x1b6XsbxmDm9If6tKFLfDwgnFALg8dGlqL8ezE64RpPwpm7SP6yH9ZcnJYeyNy/v
w8czPQTEcktG0hxWSsbg2uRpg5ZxTCk3Z7XKjOP+LCafJVljuOrnifHIknBfOkJ3
zJ4Zi921v6gJADzeT7oA51ggx1iyMqMfXAywLHb1g7/9huhigKqR96XY5GhuOvv9
k0ZT8yYWVjuyYRxkGIAKOVeEKRyafUMo/IZ9Z0+FkCmpArAydoDD0uh2BwpsCE9D
K53xhz3Wkrkigk9Q//jvAyCB2zZSslXM1/BXO9Q7YdDVlHRAp0mPW7yVLMKEC05F
A+R/fXYgYzMwe1Q2XNEuAkAG/Ym9xb1cDNk60PfzSpvC8BCdb+iR3udtGkUpi2W8
VYVS3MBkFf+wcQBlTmRaQqcm6KCh8q8AYor07OPVdZA8fpSdCOUmap377G13pW18
UHkkaahJDC0s4+/goqkOeUb0As52i5Lqw535ETenivWfhF0fRPP9Xdd64KpLoQFF
+9BnzO7fx+j15nNbSkU=
=JCY4
-----END PGP SIGNATURE-----
diffstat for chrony-3.0 chrony-3.0
changelog | 8 +++++
patches/fix_time_smoothing_in_interleaved_mode.patch | 26 +++++++++++++++++++
patches/series | 1
3 files changed, 35 insertions(+)
diff -Nru chrony-3.0/debian/changelog chrony-3.0/debian/changelog
--- chrony-3.0/debian/changelog 2017-01-18 15:26:31.000000000 +0100
+++ chrony-3.0/debian/changelog 2017-02-07 00:37:24.000000000 +0100
@@ -1,3 +1,11 @@
+chrony (3.0-3) unstable; urgency=medium
+
+ * debian/patches/*:
+ - Backport an upstream patch to fix time smoothing in interleaved mode.
+ (Closes: #854424)
+
+ -- Vincent Blut <vincent.debian@free.fr> Tue, 07 Feb 2017 00:37:24 +0100
+
chrony (3.0-2) unstable; urgency=medium
* debian/chrony.conf:
diff -Nru chrony-3.0/debian/patches/fix_time_smoothing_in_interleaved_mode.patch chrony-3.0/debian/patches/fix_time_smoothing_in_interleaved_mode.patch
--- chrony-3.0/debian/patches/fix_time_smoothing_in_interleaved_mode.patch 1970-01-01 01:00:00.000000000 +0100
+++ chrony-3.0/debian/patches/fix_time_smoothing_in_interleaved_mode.patch 2017-02-05 22:38:22.000000000 +0100
@@ -0,0 +1,26 @@
+Description: Fix time smoothing in interleaved mode
+ When the server's transmit timestamp was updated with a kernel/HW timestamp,
+ it didn't include the time smoothing offset. If the offset was larger than
+ one second, the update failed and clients using the interleaved mode received
+ less accurate timestamps. If the update succeeded, the clients received
+ timestamps that were not adjusted for the time smoothing offset, which added
+ an error of up to 0.5s/1s to their measured offset/delay.
+
+ Fix the update to include the smoothing offset in the new timestamp.
+Author: Miroslav Lichvar <mlichvar@redhat.com>
+Origin: https://git.tuxfamily.org/chrony/chrony.git/commit/?id=da2d33e9a84baa7325503440099dd8f1e567cdd4
+Applied-Upstream: 3.1
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/ntp_core.c
++++ b/ntp_core.c
+@@ -2016,6 +2016,9 @@ NCR_ProcessTxUnknown(NTP_Remote_Address
+ if (log_index < 0)
+ return;
+
++ if (SMT_IsEnabled() && NTP_LVM_TO_MODE(message->lvm) == MODE_SERVER)
++ UTI_AddDoubleToTimespec(&tx_ts->ts, SMT_GetOffset(&tx_ts->ts), &tx_ts->ts);
++
+ CLG_GetNtpTimestamps(log_index, &local_ntp_rx, &local_ntp_tx);
+
+ if (UTI_IsZeroNtp64(local_ntp_tx))
diff -Nru chrony-3.0/debian/patches/series chrony-3.0/debian/patches/series
--- chrony-3.0/debian/patches/series 2017-01-16 17:33:37.000000000 +0100
+++ chrony-3.0/debian/patches/series 2017-02-05 22:09:43.000000000 +0100
@@ -0,0 +1 @@
+fix_time_smoothing_in_interleaved_mode.patch
Reply to: