[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825534: jessie-pu: package backuppc/3.3.0-2



On Fri, May 27, 2016 at 04:35:26PM +0100, Adam D. Barratt wrote:
> How do any of these changes relate to the samba update?
> 
> > +-$Conf{BackupZeroFilesIsFatal} = 1;
> > ++$Conf{BackupZeroFilesIsFatal} = 0;

Hi!

Yes this first one is necessary because with the new smbclient,
backuppc cannot count how many files were backed-up resulting
in empty backups.

> [...]
> > - #
> > - # URL of the BackupPC_Admin CGI script.  Used for email messages.
> >   #
> >  -$Conf{CgiURL} = 'http://XXXXXX/backuppc/index.cgi';
> >  +$Conf{CgiURL} = 'http://'.$Conf{ServerHost}.'/backuppc/index.cgi';

It's the URL used for sent emails. I'm surprised that it's in the diff,
since this bug was fixed years ago...

> [...]
> > --- backuppc-3.3.0.orig/lib/BackupPC/CGI/Browse.pm
> > +++ backuppc-3.3.0/lib/BackupPC/CGI/Browse.pm
> > @@ -65,7 +65,7 @@
> >      #
> >      # default to the newest backup
> >      #
> > -    if ( !defined($In{num}) && defined(@Backups) && @Backups > 0 ) {
> > +    if ( !defined($In{num}) && @Backups && @Backups > 0 ) {

Very strange... I'll remove this patch.

Best regards,

-- 
Ludovic Drolez.

http://www.aopensource.com             - The Android Open Source Portal
http://www.drolez.com         - Personal site - Linux and Free Software


Reply to: