[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#780285: unblock: roger-router/1.8.9-2jessie1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package roger-router

Dear Release Team,

as maintainer of the roger-router package I would like to upload a fix
for #774116.  I've already uploaded a fix to experimental and I would
like to upload it to unstable as 1.8.9-2jessie1 and have it migrate
eventually.  I'd like to request a freeze exception before actually
doing that.

Faxing via the FritzBox device is one of the important functions of
Roger Router.  It is currently known-broken in testing.  The background
is that upstream has a makefile switch "--with-cups" which when set to
yes builds an experimental, known-broken cups-support.  Building as
"--with-cups=no" actually builds the working CUPS support. Go figure!
That tripped me and I would like to correct this mistake before jessie
gets released.

Regards

Rolf Leggewie

unblock roger-router/1.8.9-2jessie1
>From a59161f6e088cf254438946433f7ef373fded9ba Mon Sep 17 00:00:00 2001
From: Rolf Leggewie <foss@rolf.leggewie.biz>
Date: Sat, 8 Nov 2014 22:59:00 +0800
Subject: [PATCH 1/2] do not build the experimental (!) cups backend. Closes: #774116
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

OMG.  the compilation switch "--with-cups" doesn't mean what
you'd expect.  It means "build the experimental, known-broken,
WIP (!) version of cups-support", and disable the standard,
working cups backend. Who in their right mind would expect
that kind of semantic?

Of course, upstream didn't document this anywhere. Grr!

I was unable to verify this personally, but Dieter Schäfer and
Markus Grunwald kindly confirmed that the test packages I put out
for the purpose work fine for him. Thanks!
---
 debian/control                   | 2 --
 debian/libroutermanager0.symbols | 2 +-
 debian/roger-router-cli.install  | 3 +--
 debian/rules                     | 3 +--
 4 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/debian/control b/debian/control
index a1df6d4..b660a8f 100644
--- a/debian/control
+++ b/debian/control
@@ -6,9 +6,7 @@ Uploaders: Jan-Michael Brummer <jan.brummer@tabos.org>
 Build-Depends: debhelper (>= 9), dh-autoreconf,
  libappindicator3-dev,
  libcapi20-dev (>= 1:3.24),
- libcups2-dev,
  libebook1.2-dev,
- libgconf2-dev,
  libgstreamer1.0-dev, libgstreamer-plugins-base1.0-dev,
  libgtk-3-dev,
  libnotify-dev,
diff --git a/debian/libroutermanager0.symbols b/debian/libroutermanager0.symbols
index 1d29ec1..7e302d9 100644
--- a/debian/libroutermanager0.symbols
+++ b/debian/libroutermanager0.symbols
@@ -81,7 +81,7 @@ libroutermanager.so.0 libroutermanager0 #MINVER#
  fax_send@Base 1.8.4
  fax_set_log_level@Base 1.8.4
  fax_spandsp_workaround@Base 1.8.4
- fax_spooler_new_dir_cb@Base 1.8.4
+#MISSING: 1.8.9-2# fax_spooler_new_dir_cb@Base 1.8.4
  fax_transfer@Base 1.8.4
  faxophone_close@Base 1.8.4
  faxophone_connect@Base 1.8.4
diff --git a/debian/roger-router-cli.install b/debian/roger-router-cli.install
index d8d4c6b..1379a1c 100644
--- a/debian/roger-router-cli.install
+++ b/debian/roger-router-cli.install
@@ -1,8 +1,7 @@
 usr/bin/roger_cli
 usr/lib/*/routermanager/
-usr/lib/cups/backend/roger-cups
 usr/share/man/*/roger_cli*
-usr/share/roger/roger-cups
+usr/share/roger/roger-cups usr/lib/cups/backend/
 usr/share/roger/roger-fax.ppd
 usr/share/roger/install-fax.sh
 
diff --git a/debian/rules b/debian/rules
index 95b94a1..c7c5f2f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,7 +13,6 @@ override_dh_auto_configure:
 	dh_auto_configure -- \
 		--with-spandsp=6 \
 		--with-libnotify=yes \
-		--with-cups=yes \
 		--with-secret=yes \
 		--with-ebook=yes \
 		--with-gstreamer1=yes \
@@ -32,7 +31,7 @@ override_dh_install:
 
 override_dh_fixperms:
 	dh_fixperms
-	chmod 755 debian/roger-router-cli/usr/share/roger/roger-cups
 	chmod 755 debian/roger-router-cli/usr/share/roger/install-fax.sh
+	chmod 755 debian/roger-router-cli/usr/lib/cups/backend/roger-cups
 	chown lp.fax debian/roger-router-cli/var/spool/roger
 	chmod 2770 debian/roger-router-cli/var/spool/roger
-- 
1.9.1

>From d89739a8fceda7f2b0897476f8b4daf42ab53428 Mon Sep 17 00:00:00 2001
From: Rolf Leggewie <foss@rolf.leggewie.biz>
Date: Sat, 7 Mar 2015 15:39:51 +0800
Subject: [PATCH 2/2] README.Debian: add some information on how to send a fax

---
 debian/README.Debian | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/debian/README.Debian b/debian/README.Debian
index 13996bd..8bb1f9f 100644
--- a/debian/README.Debian
+++ b/debian/README.Debian
@@ -1,3 +1,5 @@
+= Configuration =
+
 configuration help is available from
 
 http://wiki.ubuntuusers.de/FritzBox/Roger_Router
@@ -8,8 +10,15 @@ http://en.tabos.org/installation-prequel
 If you want to use the incoming call notification you will have to enable
 it on your fritzbox with: #96*5*
 
+Please note, quick reconnect & display external ip in tooltip for Fritz!Box
+needs active UPnP support!
+
+= Fax support =
+
 If you want to use the capifax plugin you will have to enable capi-over-tcp
 on your fritzbox with: #96*3*
 
-Please note, quick reconnect & display external ip in tooltip for Fritz!Box
-needs active UPnP support!
+Roger installs a Cups printer.  To be able to fax, you either need to use
+roger_cli where you specify all necessary information including the number
+to send to on the command line or you should have Roger GUI running and it
+will prompt you for the receiving Fax number.
-- 
1.9.1


Reply to: