Re: Bug#655179: pastebinit does not read .conf files from ~/.pastebin.d/ directory
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Severity: important
thank you
Max,
thank you for your report. You request a backport of upstream commit
r81 to version 1.1-2 of pastebinit in Squeeze. I'm willing to do that
as I believe your request has merit, but I'd like to hear from the
Stable Release Team first what they think. They will be the final
arbiter of any upload to a stable release.
r81 entered Debian Experimental in 1.2-2 on February 2nd last year.
Subsequently 1.2-3 was uploaded to Unstable on July 4th. There has
been no negative feedback regarding this change in either Debian or
Ubuntu and it's highly unlikely to cause any regression due to the
minimal and obviously beneficial change it introduces. I'm bumping
this ticket to severity important since the faulty code greatly
diminishes the ability of ordinary users to customize their
interaction with a pastebin as you pointed out. I'm including your
original report as a full-quote below for the convenience of the
Stable Release Team.
Regards
Rolf
On 09.01.2012 02:06, Maximilian Gerhard wrote:
> Version: 1.1-2 Tags: squeeze patch
>
> Users can not override pastebinit global config or add own service
> configs via ~/.pastebin.d conf files. This directory is not read
> by pastebinit, because of an indention error in pastebinit code.
>
> Only chance for users to override or add configs is to receive
> root priviliges and change /etc/pastebin.d. For example to edit
> the expire time for paste.debian.net (7 days as default is a
> really long time, even the website offers only 72h as maximum).
> Changing global configs has the disadvantage of checksum mismatch
> while new updates occour. And of course not every user has the
> possibility to become root. Even if, this is not the prefered way
> because pastebinit offers the possibility to use a local config
> directory for users.
>
> You can test the bug if you move a config from /etc/pastebin.d to
> ~/.pastebin.d and make a paste to this service. You will get an
> error that this service is unknown.
>
> The problem is an indention error in pastebinit function "def
> preloadPastebins()". There are 2 nested for-loops. First to
> iterate all config directories and the second to read all conf
> files inside of an config directory. The return of the first loop
> has a too deep indention so it is executed after the first run of
> the second for-loop. That means that pastebinit does only read the
> conf files from the first config directory.
>
> This bug was filled already for Ubuntu, see
> https://bugs.launchpad.net/ubuntu/+source/pastebinit/+bug/701039
> There is a fix mentioned in comment #2 in revision 81, see
> http://bazaar.launchpad.net/~pastebinit-developers/pastebinit/trunk/revision/81
>
> The patch just change the indention of the return so it will be
> executed just after iteration of all config directories.
>
> Best regards, Max
>
>
>
> -- System Information: Debian Release: 6.0.3 APT prefers stable
> APT policy: (500, 'stable') Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.2.0-030200-generic (SMP w/4 CPU cores) Locale:
> LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell:
> /bin/sh linked to /bin/dash
>
> Versions of packages pastebinit depends on: ii python
> 2.6.6-3+squeeze6 interactive high-level object-orie ii
> python-configobj 4.7.2+ds-1 simple but powerful
> config file re
>
> pastebinit recommends no packages.
>
> pastebinit suggests no packages.
>
> -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJPCmI/AAoJEJSEK8huURwxvysQAJgib1NKprBA0w6299b1Y6sl
IIGh+Ee5yQx10i1sRCjNuduYOfHZ6TrUZzAKSn3ZjdSCR8uFmUL0AIXDxJGtSI1H
2Zd9wZ0RZs00CTmALUr3aVJuh+XuZyMwRKQq1E/q+hbwN07hdQi8/7tnzkGILXD7
jVEZD5wTCNffnCQ7c88v9EThs1EA70YDQSH9ZcQJohu+KS6QHKpKIMNOkp4RhUS5
6Kwx42yRtOzJQdBmLSSq2LzboFp4LZBYvixPrrTE37c1EG905q34+Vp5Eo6vNGUc
Al3+65Afx4ME5Cigb0yh2YPagLmIPtiOCp1S66XNxzpXpaiNvhyjCNP5UkaBr7Ui
QCThrnENDpEjIvuS3sAi3VwBKOxCQWnNV7Zv2gbmzp+QSYmyevlsM6ztvu1dE5yM
i/KOhf/mpoiVSFVhsK9H489iYWea+5U8jiAZFU+Y2dTF/xJKnwGkL6VOhF9dFOl5
wJPixr9I2p7URgxxe8Aa+oquQokk3tBL1j9A2D9VhIhEozGLQn3lXnrhM7wmJQje
6EN0i3NWebLPOD5YSWHrvn1w12hWvzCjGgu09CGfNBvv8enA9LVxNsh1HOCELt0Q
pBJ/jBEXrEWtGBsc2ORNBuKQ9LPeVNijIGrKQeOXmuBMoh49MAFOCKxllivOww0Z
gWy5b0b+w5FTlXFfPN0j
=li/w
-----END PGP SIGNATURE-----
Reply to: