[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689000: unblock: remctl/3.2-4



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package remctl.  This version fixes a file descriptor
leak in the daemon that becomes visible with long-running processes.
It doesn't have a Debian bug since the problem was discovered upstream,
but the problem caused a production outage at Stanford and the fix is
so trivial as to be quite low risk.

The debdiff is attached.

unblock remctl/3.2-4

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-3-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru remctl-3.2/debian/changelog remctl-3.2/debian/changelog
--- remctl-3.2/debian/changelog	2012-06-28 13:57:33.000000000 -0700
+++ remctl-3.2/debian/changelog	2012-09-27 21:13:18.000000000 -0700
@@ -1,3 +1,10 @@
+remctl (3.2-4) unstable; urgency=low
+
+  * Cherry-pick upstream fix to close a file descriptor leak in remctld
+    when checking access against ACL files.
+
+ -- Russ Allbery <rra@debian.org>  Thu, 27 Sep 2012 21:12:59 -0700
+
 remctl (3.2-3) unstable; urgency=low
 
   * Cherry-pick upstream fix to flags passed to open() when creating
diff -Nru remctl-3.2/debian/patches/debian-changes remctl-3.2/debian/patches/debian-changes
--- remctl-3.2/debian/patches/debian-changes	2012-06-28 13:58:15.000000000 -0700
+++ remctl-3.2/debian/patches/debian-changes	2012-09-27 21:15:11.000000000 -0700
@@ -76,3 +76,13 @@
      if (marker < 0)
          sysbail("cannot create marker file");
      conn = accept(fd, NULL, 0);
+--- remctl-3.2.orig/server/config.c
++++ remctl-3.2/server/config.c
+@@ -632,6 +632,7 @@ acl_check_file_internal(void *data, cons
+             return s;
+         }
+     }
++    fclose(file);
+     return CONFIG_NOMATCH;
+ 
+ fail:

Reply to: