Bug#681816: Unblock paraview/3.14.1-7
On Wed, 2012-08-08 at 02:47 +0200, Cyril Brulebois wrote:
> Anton Gladky <gladky.anton@gmail.com> (16/07/2012):
> > Please unblock package paraview_3.14.1-7.
> >
> > The version fixes bug #680359 and has some minor fixes, including hardening
> > build-flags. Diff is attached.
>
> | paraview (3.14.1-7) unstable; urgency=low
[...]
> | * [155d23c] Use compat 9 to harden buildflags.
>
> I'm not sure I'm really happy with this. Switching from dh 8 to dh 9
> means 9 incompatibilities (see debhelper(7) for details). Given how all
> vtk-related packages are fragile as far as the build system is concerned
> (at least IIRC), I'm not really keen on checking myself that nothing
> broke by bumping the debhelper compat…
Indeed. I probably wouldn't be averse to a solution that applied the
flags by another means.
> | * [bdef31b] Add -Wall -pedantic -Wl,--as-needed to buildflags.
>
> ACK on principle for the first two. Introducing --as-needed can cause
> subtle bugs, so I'm not very happy see this during a freeze either.
Agreed. What's the reasoning behind changing the flags at this point?
Regards,
Adam
Reply to: