Re: stable-proposed-updates: considering cpufrequtils
On Tue, Nov 22, 2011 at 09:09:25PM +0000, Adam D. Barratt wrote:
> On Tue, 2011-11-15 at 06:50 +0900, Mattia Dongili wrote:
> > On Sun, Nov 13, 2011 at 05:33:10PM +0000, Adam D. Barratt wrote:
> > > On Mon, 2011-09-19 at 07:52 +0900, Mattia Dongili wrote:
[...]
> > > > + * Bulk load only helper modules. Linux 3.0 shuffled cpufreq modules
> > > > + locations a bit and now cpu drivers and helpers are in the same directory
> > > > + (closes: #636141).
> > > > + * Use modprobe -b in loadcpufreq to honour blacklisted modules
> > > > + (closes: #592488).
> > > > + * Load powernow-k8 for AMD family 20 (i.e. AMD E-350 cpus)
> > > > + (closes: #627811).
> > > > + * Stop changing printk levels when loading cpufreq modules (closes: #624575
> > > > + and closes: #596235).
> > >
> > > I've been debating whether to accept all of the changes, and changed my
> > > mind a few times while arguing with myself. :-) Have the changes been
> >
> > what is your current stance? :)
>
> I'm edging towards acking all of them, but it partly depends on:
>
> > > tested on a stable system?
> >
> > To be honest I haven't tried it myself on a stable system but I'll give
> > it a go in the next days (towards the weekend most likely). The change
> > that my have a funny dependency is the "-b" addition to modprobe but
> > other than that it's all pretty safe and it's mostly removing
> > unnecessary code or making the find predicate more specific.
> > On the other hand there are a couple of backports of the whole package
> > already so I don't expect many surprises.
>
> Did you have chance to do the testing you mentioned here?
just finished giving it a go on a squeeze virtual machine (yay for
national holidays!!).
loadcpufreq (the one with all the changes mentioned above) obviously
cannot detect a supported cpu but all the changed code is executed fine.
Attached a verbose log of the execution.
cpufrequtils (007-2+squeeze1) stable; urgency=low
* Recompile for Squeeze.
-- Mattia Dongili <malattia@debian.org> Wed, 23 Nov 2011 09:32:00 +0900
Thanks!
--
mattia
:wq!
+ PATH=/sbin:/bin:/usr/sbin:/usr/bin
+ NAME=loadcpufreq
+ . /lib/lsb/init-functions
+ FANCYTTY=
+ [ -e /etc/lsb-base-logging.sh ]
+ true
+ [ -f /etc/default/rcS ]
+ . /etc/default/rcS
+ TMPTIME=0
+ SULOGIN=no
+ DELAYLOGIN=no
+ UTC=yes
+ VERBOSE=no
+ FSCKFIX=no
+ RAMRUN=no
+ RAMLOCK=no
+ ENABLE=true
+ [ -f /etc/default/loadcpufreq ]
+ set -e
+ [ true = true ]
+ MODPROBE=modprobe -b
+ log_action_begin_msg Loading cpufreq kernel modules
+ echo -n Loading cpufreq kernel modules...
Loading cpufreq kernel modules...+ [ -f /proc/modules ]
+ load_modules
+ /sbin/lsmod
+ awk !/Module/ {print $1}
+ LIST=loop
joydev
usbhid
hid
snd_intel8x0
snd_ac97_codec
ac97_bus
snd_pcm
i2c_piix4
snd_timer
psmouse
i2c_core
snd
soundcore
snd_page_alloc
pcspkr
evdev
virtio_balloon
serio_raw
processor
button
ext3
jbd
mbcache
sg
sr_mod
cdrom
ata_generic
uhci_hcd
ata_piix
libata
ehci_hcd
virtio_net
virtio_blk
floppy
scsi_mod
usbcore
nls_base
virtio_pci
virtio_ring
virtio
thermal
thermal_sys
+ uname -r
+ LOC=/lib/modules/2.6.32-5-amd64/kernel/drivers/cpufreq
+ [ -d /lib/modules/2.6.32-5-amd64/kernel/drivers/cpufreq ]
+ find /lib/modules/2.6.32-5-amd64/kernel/drivers/cpufreq -type f+ name cpufreq_*.o -printf basename %f .o\n
/bin/sh
+ find /lib/modules/2.6.32-5-amd64/kernel/drivers/cpufreq -type f -name cpufreq_*.ko -printf basename %f .ko\n
+ MODAVAIL=cpufreq_stats
cpufreq_conservative
cpufreq_powersave
cpufreq_userspace
+ echo loop joydev usbhid hid snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_piix4 snd_timer psmouse i2c_core snd soundcore snd_page_alloc pcspkr evdev virtio_balloon serio_raw processor button ext3 jbd+ bcache sg sr_mod cdromgrep -q -w cpufreq_stats
_piix libata ehci_hcd virtio_net virtio_blk floppy scsi_mod usbcore nls_base virtio_pci virtio_ring virtio thermal thermal_sys
+ modprobe -b cpufreq_stats
+ echo+ oop joydev usbhidgrep -q -w cpufreq_conservative
ac97_bus snd_pcm i2c_piix4 snd_timer psmouse i2c_core snd soundcore snd_page_alloc pcspkr evdev virtio_balloon serio_raw processor button ext3 jbd mbcache sg sr_mod cdrom ata_generic uhci_hcd ata_piix libata ehci_hcd virtio_net virtio_blk floppy scsi_mod usbcore nls_base virtio_pci virtio_ring virtio thermal thermal_sys
+ modprobe -b cpufreq_conservative
+ echo loop joydev usbhid hid snd_intel8x0 snd_ac97_codec ac97_bus+ nd_pcm i2c_piix4 snd_timer psmouse i2c_coregrep -q -w cpufreq_powersave
pcspkr evdev virtio_balloon serio_raw processor button ext3 jbd mbcache sg sr_mod cdrom ata_generic uhci_hcd ata_piix libata ehci_hcd virtio_net virtio_blk floppy scsi_mod usbcore nls_base virtio_pci virtio_ring virtio thermal thermal_sys
+ modprobe -b cpufreq_powersave
+ echo loop joydev usbhid hid snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_piix4 snd_timer psmouse i2c_core snd soundcore snd_page_alloc pcspkr evdev virtio_balloon serio_raw processor button ext3 jbd mbcache sggrep -q -w cpufreq_userspace
i_hcd ata_piix libata ehci_hcd virtio_net virtio_blk floppy scsi_mod usbcore nls_base virtio_pci virtio_ring virtio thermal thermal_sys
+ modprobe -b cpufreq_userspace
+ uname -m
+ [ x86_64 = ppc ]
+ [ ! = ]
+ load_detected_cpufreq_modules
+ CPUINFO=/proc/cpuinfo
+ IOPORTS=/proc/ioports
+ [ ! -f /proc/cpuinfo ]
+ grep ^model name /proc/cpuinfo
+ head -1
+ sed -e s/^.*: //;
+ MODEL_NAME=QEMU Virtual CPU version 0.14.1
+ grep -E ^model[[:space:]]+: /proc/cpuinfo
+ head -1
+ sed -e s/^.*: //;
+ MODEL_ID=2
+ grep -E ^cpud[^:]+: /proc/cpuinfo
+ head -1
+ sed -e s/^.*: //;
+ CPU=
+ grep -E ^vendor_id[^:]+: /proc/cpuinfo
+ head -1
+ sed -e s/^.*: //;
+ VENDOR_ID=GenuineIntel
+ sed -e /^cpu family/ {s/.*: //;p;Q};d /proc/cpuinfo
+ CPU_FAMILY=6
+ MODULE=
+ MODULE_FALLBACK=acpi-cpufreq
+ [ -f /proc/ioports ]
+ grep -q Intel .*ICH /proc/ioports
+ PIII_MODULE=speedstep-ich
+ grep est /proc/cpuinfo
+ [ ]
+ [ 6 = 15 ]
+ [ ! -z ]
+ [ ! -z acpi-cpufreq ]
+ [ ! -z ]
+ modprobe -b acpi-cpufreq
+ unset MODULE
+ check_kernel
+ CPUFREQ=/sys/devices/system/cpu/cpu0/cpufreq
+ [ -z ]
+ return 0
+ [ -z ]
+ MODULE=none
+ log_action_end_msg 0 none
+ log_action_end_msg_pre 0 none
+ :
+ [ -z none ]
+ end= (none).
+ [ 0 -eq 0 ]
+ echo done (none).
done (none).
+ log_action_end_msg_post 0 none
+ :
+ exit 0
Reply to: