On Sun, Aug 29, 2010 at 23:31:59 +0200, Nicolas François wrote: > Dear RMs, > > On Sat, Aug 28, 2010 at 12:11:39PM +0200, Mehdi Dogguy wrote: > > > > Any news regarding shadow's upload? > > I've prepared this package for review/approval before an upload: > http://alioth.debian.org/~nekral-guest/packages/shadow/ > Lots of noise in the diff (reformatting, random coding style stuff), makes it a pain to review. :/ A question about the change to libmisc/chowndir::chown_tree() - if (strlen (root) + strlen (ent->d_name) + 2 > sizeof new_name) - break; + if (strlen (root) + strlen (ent->d_name) + 2 > new_name_len) { + new_name = realloc (new_name, new_name_len + 1024); + if (NULL == new_name) { + rc = -1; + break; + } + new_name_len += 1024; + } AFAICT you're leaking new_name if realloc() fails? Also it might be better to either change the outer 'if' to a 'while', or check that the new size is big enough before continuing to the snprintf. And a few random comments... libmisc/copydir.c: + * When reset_selinux is enabled, extended attributes (and thus + * SELinux attributes are not copied. missing `)' libmisc/remove_tree.c: checks for NULL before free(), not necessary. src/faillog.c: reindents ftl. I had to give up on src/usermod.c, the argument parsing changes need context and it's too late for that. Seems ok overall, but really really late for that many changes in a required package. Cheers, Julien
Attachment:
signature.asc
Description: Digital signature